Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-5888: Hide existing VC services from option list to prevent duplicates. #5915

Conversation

ethanteague
Copy link
Contributor

Description

Closes #5888

Testing done

Visual

QA steps

  • As an administrator, go to node/3756/edit.
  • Add a service, and visually verify only options that are not selected in the table above appear.
  • Remove items from the table, and verify that they appear in the select.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • Core Application Team
  • Product Support Team

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing annoucement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping @ rachel-kauff so she's ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping @ rachel-kauff to prompt her to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 20, 2021 22:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 21, 2021 18:15 Destroyed
Copy link
Contributor

@kevwalsh kevwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Pass, over to @swirtSJW for CR

@kevwalsh kevwalsh requested a review from swirtSJW July 22, 2021 13:44
@kevwalsh kevwalsh changed the title VACMS-5888: Add logic to remove selected services from dropdown. VACMS-5888: Hide existing VC services from option list to prevent duplicates. Jul 29, 2021
});

newServiceValueSelector.forEach((i) => {
// Sanity reset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure what this comment means.

@swirtSJW
Copy link
Contributor

image

@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 29, 2021 18:43 Destroyed
@swirtSJW swirtSJW merged commit bc076cf into department-of-veterans-affairs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent duplicate services added to a single Vet Center
4 participants