Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity Dashboard (FE) - Fix metadata on Homepage #62407

Closed
1 task done
asg5704 opened this issue Jul 21, 2023 · 3 comments
Closed
1 task done

Identity Dashboard (FE) - Fix metadata on Homepage #62407

asg5704 opened this issue Jul 21, 2023 · 3 comments
Assignees
@acald-creator
Labels
Identity All Identity related tickets identity-frontend

Comments

@asg5704
Copy link
Contributor

asg5704 commented Jul 21, 2023 •
edited by acald-creator
Loading

Description

Fix the pages that use use client to ensure the metadata like title and description are updated

Tasks

  • Ensure localhost:3001 does not show up in the title
@asg5704 asg5704 added Identity All Identity related tickets identity-frontend labels Jul 21, 2023
@acald-creator acald-creator self-assigned this Jul 31, 2023
@acald-creator acald-creator changed the title Identity Dashboard (FE) - Fix metadata Identity Dashboard (FE) - Fix metadata on Homepage Aug 18, 2023
@acald-creator
Copy link

Update: open PR https://github.com/department-of-veterans-affairs/identity-dashboard-fe/pull/60

Working on updating the test to include the new changes.

@acald-creator
Copy link

Blocked: jest test failed due to metadata works in the server component, not client component

Open issue for reference:

vercel/next.js#47299 (comment)

Will see if the workaround works for now.

@acald-creator
Copy link

Next.js updated their with-jest example from this PR. vercel/next.js#54989

Testing this current PR to see if I get the test passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acald-creator acald-creator

Labels
Identity All Identity related tickets identity-frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acald-creator @asg5704 @kingbmike