Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag for manual review design doc #6138

Merged
merged 28 commits into from Jul 24, 2020
Merged

Flag for manual review design doc #6138

merged 28 commits into from Jul 24, 2020

Commits on Feb 20, 2020

  1. Create flag-for-manual-review.md 

    More revisions will follow
    @bkjohnson
    bkjohnson committed Feb 20, 2020
    Copy the full SHA
    02e3f8c View commit details
    Browse the repository at this point in the history

  2. Add some more overview info

    @bkjohnson
    bkjohnson committed Feb 20, 2020
    Copy the full SHA
    cdd178c View commit details
    Browse the repository at this point in the history

  3. Add some specifics

    @bkjohnson
    bkjohnson committed Feb 20, 2020
    Copy the full SHA
    375099d View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Add some more details

    @bkjohnson
    bkjohnson committed Feb 25, 2020
    Copy the full SHA
    0c1f5dc View commit details
    Browse the repository at this point in the history

  2. Remove some remplate info

    @bkjohnson
    bkjohnson committed Feb 25, 2020
    Copy the full SHA
    56b9b14 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Merge branch 'master' into bkjohnson/flag-for-manual-review-doc

    @bkjohnson
    bkjohnson committed Mar 2, 2020
    Copy the full SHA
    8656751 View commit details
    Browse the repository at this point in the history

  2. Add more info on what triggers a manual review

    @bkjohnson
    bkjohnson committed Mar 2, 2020
    Copy the full SHA
    c7164ad View commit details
    Browse the repository at this point in the history

  3. Add a caveat

    @bkjohnson
    bkjohnson committed Mar 2, 2020
    Copy the full SHA
    a1b7693 View commit details
    Browse the repository at this point in the history

  4. Move into design-docs folder

    @bkjohnson
    bkjohnson committed Mar 2, 2020
    Copy the full SHA
    afe6eef View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Fix typo 

    Co-Authored-By: Rian Fowler <rian.fowler@adhocteam.us>
    @bkjohnson
    bkjohnson and Rian Fowler committed Mar 3, 2020
    Copy the full SHA
    c8a2b88 View commit details
    Browse the repository at this point in the history

  2. Remove harsh-sounding non-goal 

    Co-Authored-By: Rian Fowler <rian.fowler@adhocteam.us>
    @bkjohnson
    bkjohnson and Rian Fowler committed Mar 3, 2020
    Copy the full SHA
    51eccd3 View commit details
    Browse the repository at this point in the history

  3. Be more succinct about review turnaround 

    Co-Authored-By: Rian Fowler <rian.fowler@adhocteam.us>
    @bkjohnson
    bkjohnson and Rian Fowler committed Mar 3, 2020
    Copy the full SHA
    50e096f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Andrew Gunsch <andrew.gunsch@adhocteam.us>
    @bkjohnson @gunsch
    bkjohnson and gunsch committed Mar 4, 2020
    Copy the full SHA
    72a8d42 View commit details
    Browse the repository at this point in the history

  2. Update security concerns section

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    46a043b View commit details
    Browse the repository at this point in the history

  3. Add detail on how to handle the token securely

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    52934c3 View commit details
    Browse the repository at this point in the history

  4. Add more info on environment variables 

    Pulled from PR description in department-of-veterans-affairs/vets-website#11670
    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    0f4922b View commit details
    Browse the repository at this point in the history

  5. Use file extension in link 

    Co-Authored-By: Andrew Gunsch <andrew.gunsch@adhocteam.us>
    @bkjohnson @gunsch
    bkjohnson and gunsch committed Mar 4, 2020
    Copy the full SHA
    4091768 View commit details
    Browse the repository at this point in the history

  6. Move design doc out of design-docs folder 

    That seems to be just for the template
    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    d609d45 View commit details
    Browse the repository at this point in the history

  7. Fix typo in environment variables link

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    8618817 View commit details
    Browse the repository at this point in the history

  8. Add detail on discovering when process is ignored

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    c021a72 View commit details
    Browse the repository at this point in the history

  9. Add repo and file description to code location

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    5015873 View commit details
    Browse the repository at this point in the history

  10. Be more specific about testing plan

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    0e05484 View commit details
    Browse the repository at this point in the history

  11. Add a bit of background on codeowners changes

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    8225b5c View commit details
    Browse the repository at this point in the history

  12. Add detail on how the Github API is used

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    de85478 View commit details
    Browse the repository at this point in the history

  13. Fix ref case

    @bkjohnson
    bkjohnson committed Mar 4, 2020
    Copy the full SHA
    510190b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Andrew Gunsch <andrew.gunsch@adhocteam.us>
    @bkjohnson @gunsch
    bkjohnson and gunsch committed Mar 5, 2020
    Copy the full SHA
    03324b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Remove manual-review-triggers doc 

    This was pulled out and added in this PR:
- #6592
    @bkjohnson
    bkjohnson committed Jul 24, 2020
    Copy the full SHA
    c41f349 View commit details
    Browse the repository at this point in the history

  2. Mark as approved

    @bkjohnson
    bkjohnson committed Jul 24, 2020
    Copy the full SHA
    11ae901 View commit details
    Browse the repository at this point in the history