Remove HTML breaks in favor of CSS classes and components #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mantic use of bold elements
nicksayre
added a commit
that referenced
this pull request
Mar 21, 2024
* 227 - add social media links to school administrators (#895) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 166 - Updated the School Administrator webpage description. (#896) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 228 - Remove "Upcoming Events" (#898) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 229 - update "other resources" section with new content and design (#899) * 229 - update "other resources" section with new content and design * 229 - Add underlines to links --------- Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 211/231 - Remove "keywords" / add "upload a document" feature (#901) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 226 - Update breadcrumb text (#904) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 210 - Add new heading and link for GovDelivery updates (#905) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 312 - add handbooks section and "On this page" link to it (#907) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 334 - remove breaks in favor of styles, and components; remove non-semantic use of bold elements (#909) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 367 - set all links as opening in the same browsing context (#911) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 373- Overhaul the Trainings section with a new title, links and descriptions (#913) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * Add program approvals section and jump link (#912) * 314 - add program approvals section and jump link * 314 - typo --------- Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 377 - Update "Understanding Veteran education benefits" section with new heading and content (#917) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 376 - Add "Other Resources" section with content. Update the inner-page link with a corresponding title (#914) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 372 - Add link to "Handbooks" section, and fix two links to PowerPoint files (#919) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 419 - Revise "program approvals" section with latest approved content (#921) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * Rrevise "Trainings and webinars" section (#922) * 420 - Revise "Trainings and webinars" section with newest content * Update school-administrators.md update date --------- Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 375 - Remove old "upload" section in favor of new one; add inner-page link; update script so that it can affect multiple accordions (#920) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 316 - Replace call-to-action text, graphic, and link; also remove old content (#924) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 430 - Clean up introductory section and sidebar (#925) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 453 - Remove "download: icons; fix typo (#926) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 473 - Priority edits (#930) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * 475 - Update graphic, add link to Yellow Ribbon, iteration to "Payment and debt" section (#932) Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us> * Merge main --------- Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #334
Removes
<br>elements which were used for presentational purposes rather than semantic ones. To retain desired spacing, CSS classes and components are used instead.I also found this to be a good opportunity to remove
<b>elements for the same reason. The apparent usage was presentational, to make the text bold. That's not what the bold element is for, beginning with HTML 5.Screenshots to show spacing remains the same