Rename forms api module to simple forms api

[gmrabian]

The Lighthouse team has an API named Forms API so they asked us to rename ours. Since our vets-website folder is called simple-forms we've chosen to rename from forms_api to simple_forms_api

For reference: Original PR adding forms_api module

Summary

• Rename all references to forms_api to simple_forms_api, and similar references like FormsApi to SimpleFormsApi
  • Note: there is one exception of secrets mounted (config/settings.yml) and where those secrets are used, like in lib/simple_forms_api_submission because this would require changes in devops, manifests, and AWS. We are not anticipating an issue with this for now. The main concern was stack traces that said forms_api

Related issue(s)

• https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/343

Testing done

• Ran all associated tests locally and they passed

• Used postman to test multiple requests locally and they worked as expected

• Since there is no logic change the expected functionality is that vets-api starts up as expected without issues

• Updated frontend forms that submit to this endpoint and tested locally that they submit correctly

Screenshots

Forms 26-4555, 21-4142, and 21-10210 submitting locally without issues to the new endpoint

What areas of the site does it impact?

A variety of forms that are non-prod

Associated PR to update those submission endpoints

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

[gmrabian]

Looks like the failing tests are the same ones failing in master. Searching simple_forms_api yielded no results in the error log and those tests are ok locally.

[ryan-mcneil]

👍