Add confirmation number #161
Conversation
| describe '#confirmation_number' do | ||
| it 'should return the right confirmation number' do | ||
| subject.save! | ||
| expect(subject.confirmation_number).to eq("vets_gov_education_benefits_claim_#{subject.id}") |
There was a problem hiding this comment.
This feels like the test is just a replication of the code. What if you tested that you can look up the claim number and get back the same claim?
| @@ -37,6 +37,10 @@ def parsed_form | |||
| @parsed_form ||= JSON.parse(form) | |||
| end | |||
|
|
|||
| def confirmation_number | |||
| "vets_gov_#{self.class.to_s.underscore}_#{id}" | |||
There was a problem hiding this comment.
Does this get displayed to the user? Is there any reason not to create a random uuid for this? My assumption is that this is used to communicate with the call center, and I would be concerned about giving a sequential identifier without knowing what other checks the call center does to verify identity
There was a problem hiding this comment.
In an email, Shay wrote:
The confirmation number is displayed to the user when they submit. It is just used to trace the application, if needed. (We can pull up the application in VONAPP Admin based on the confirmation number).
It has no effect on the processing of the claim.
I'll ask for some followup on what "trace" means.
There was a problem hiding this comment.
There's an Admin Interface in VONAPP where admins can look up forms by submission ID, and print copies of them out. The call center just passes those confirmation numbers along to someone with access to that admin interface. We can use basically whatever we want, but we also may need to make some sort of 'retransmit' mechanism to send the 22-1990 to a different processing center.
|
@markolson which documentation? |
| @@ -42,7 +42,8 @@ Content-Type: application/json | |||
| // when it was first submitted | |||
| "submittedAt": "2016-09-09T23:48:07.766Z", | |||
| // address of the VA regional office where it will be processed | |||
| "regionalOffice": "Eastern Region\nVA Regional Office\nP.O. Box 4616\nBuffalo, NY 14240-4616" | |||
| "regionalOffice": "Eastern Region\nVA Regional Office\nP.O. Box 4616\nBuffalo, NY 14240-4616", | |||
| "confirmationNumber": "vets_gov_education_benefits_claim_18" | |||
There was a problem hiding this comment.
@lihanli this is the documentation I mentioned in the view
fixes #106