80854 appts svc using check in UUID #16432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
80854_appts_svc_using_check_in_uuid/main/main
va-vfs-bot
temporarily deployed
to
80854_appts_svc_using_check_in_uuid/main/main
va-vfs-bot
temporarily deployed
to
80854_appts_svc_using_check_in_uuid/main/main
va-vfs-bot
temporarily deployed
to
80854_appts_svc_using_check_in_uuid/main/main
ericboehs
pushed a commit
that referenced
this pull request
Apr 26, 2024
* 80854 update token service specs * 80854 update base service and specs * 80854 update appointment service specs * 80854 fix specs to get icn from Lorota Redis client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the appointments base service to use check_in session, lookup the patient icn from Redis using the check_in session uuid, and uses the MAP token service to get the token and call VAOS appointments endpoint. The base service correctly gets the patient icn using the check_in session uuid. Earlier implementations relied on the controller layer to pass in the patient icn.
This code is not currently being used, we'll be working on adding a controller implementation that uses this service to get the upcoming appointments for the patient who is checking in.
Related issue(s)
department-of-veterans-affairs/va.gov-team#80854
Testing done
Acceptance criteria