80367: Add form profile for 10-7959F-1 #16446
Conversation
|
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/10-7959F-1.yml |
|
@ndsprinkle I added you after a convo with Eric as I couldn't add a normal tests due to the doc being outdated and relying on vets-json-schema. Let me know how I can improve this if anything from a BE perspective |
va-vfs-bot
temporarily deployed
to
80367-add-prefill-10-7959f-1/main/main
| street: [contact_information, street] | ||
| city: [contact_information, city] | ||
| state: [contact_information, state] | ||
| postal_code: [contact_information, postal_code] |
There was a problem hiding this comment.
@michaelclement This might have to be adjusted in the future as right now I have physical and mailing the same but I want to see how it works first before I start making customizations if you're okay with that.
There was a problem hiding this comment.
Yeah that seems reasonable to me 👍
There was a problem hiding this comment.
Looking at other form mappings, the contact address information is being called differently. Does this work?
EX: config/form_profile_mappings/20-0996.yml
non prefill:
veteranAddress:
street: [contact_information, address, street]
street2: [contact_information, address, street2]
street3: [street3]
city: [contact_information, address, city]
state: [contact_information, address, state]
country: [contact_information, address, country]
postalCode: [contact_information, address, postal_code]
veteranSsnLastFour: [identity_information, ssn_last_four]
veteranVaFileNumberLastFour: [va_file_number_last_four]
Other form mappings:
EX: config/form_profile_mappings/10-10EZR.yml
veteranAddress: [contact_information, address]
There was a problem hiding this comment.
@balexandr Can you confirm this works? I would suggest reverting contact_information.street and etc, does not exist. contact_information.address.street does.
| @@ -101,7 +101,8 @@ class FormProfile | |||
| vre_readiness: ['28-1900'], | |||
| coe: ['26-1880'], | |||
| adapted_housing: ['26-4555'], | |||
| intent_to_file: ['21-0966'] | |||
| intent_to_file: ['21-0966'], | |||
| ivc_champva: ['10-7959F-1'] | |||
There was a problem hiding this comment.
I think we may want to name this something specific to F1 rather than ignore thisivc_champva, because as we add other ivc forms they’ll have to have unique entries in this object
@balexandr Did you try adding any tests to form_profile_spec.rb? I'm thinking something similar to the |
@rmtolmach We found this |
|
Where is that guidance from @balexandr? |
This reverts commit 6af92d9.
* Upgrade Debian to Bookworm (master) (#16454) * update debian to bookworm * add test_client.p12 * update ruby version to 2.3.3 * testing with connect_vbms 0.2.0.rc * add back ruby platform to Gemfile.lock * update connect_vbms gem to ad hoc fork * add trailing new line to Dockerfile * 80367: Add form profile for 10-7959F-1 (#16446) * 80367: Add form profile for 10-7959F-1 * 80367: Remove vets-json-schema test * 80367: Add codeowner * fix error response for submit inquiry and reply (#16480) Co-authored-by: khoa-v-nguyen <khoa.nguyen@oddball.io> --------- Co-authored-by: stevenjcumming <134282106+stevenjcumming@users.noreply.github.com> Co-authored-by: Bryan Alexander <bryan.alexander@adhocteam.us> Co-authored-by: Khoa Nguyen <134089461+Khoa-V-Nguyen@users.noreply.github.com> Co-authored-by: khoa-v-nguyen <khoa.nguyen@oddball.io>
* added prefill for 10-7959c * linting fixes * added codeowners for 10-7959c mapping file * adjusting form naming * updated list formatting * adjusted to be in line with example set in #16446
Add back-end logic to enable prefill for vets-website.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?