-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct deposit logs #16453
Add direct deposit logs #16453
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -84,7 +100,7 @@ def control_info_params | |||
:has_no_fiduciary_assigned, | |||
:is_not_deceased, | |||
:has_payment_address, | |||
:has_indentity) | |||
:has_identity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Summary
control_information
to useActiveModel::Attributes
andActiveModel::AttributeAssignment
. This helped with coercing request parameters.Related issue(s)
department-of-veterans-affairs/va.gov-team#79250
Testing done
Added/updated specs in: