Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct deposit logs #16453

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add direct deposit logs #16453

merged 2 commits into from
Apr 24, 2024

Conversation

tpharrison
Copy link
Contributor

@tpharrison tpharrison commented Apr 23, 2024

Summary

  • Add temporary logging to controller.
  • Refactored control_information to use ActiveModel::Attributes and ActiveModel::AttributeAssignment. This helped with coercing request parameters.
  • Added/updated specs.

Related issue(s)

department-of-veterans-affairs/va.gov-team#79250

Testing done

Added/updated specs in:

  • direct_deposits_controller_spec
  • control_information_spec

Copy link

1 Warning
⚠️ This PR changes 215 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • app/controllers/v0/profile/direct_deposits_controller.rb (+23/-7)

  • lib/lighthouse/direct_deposit/control_information.rb (+55/-25)

  • spec/controllers/v0/profile/direct_deposits_controller_spec.rb (+43/-1)

  • spec/lib/lighthouse/direct_deposit/control_information_spec.rb (+47/-14)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@adamwhitlock1 adamwhitlock1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -84,7 +100,7 @@ def control_info_params
:has_no_fiduciary_assigned,
:is_not_deceased,
:has_payment_address,
:has_indentity)
:has_identity)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@tpharrison tpharrison merged commit 1e50563 into master Apr 24, 2024
23 checks passed
@tpharrison tpharrison deleted the add-direct-deposit-logs branch April 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants