Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DBX-80624] add 526 states for remediation audit #16455

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[DBX-80624] add 526 states for remediation audit #16455

merged 2 commits into from
Apr 24, 2024

Conversation

SamStuckey
Copy link
Contributor

@SamStuckey SamStuckey commented Apr 23, 2024 •
edited

Summary

  • This work is behind a feature toggle (flipper): NO
  • Two new states are being added to support the 526 state Audit (code yellow). These are part of a larger project to 'exclude' submissions that have been processed, leaving us with a list of 'untouched' submissions
  • The 526 'state machine' is really more of an end-of-life tagging system that was introduced to support our remediation and state auditing following multiple related code yellows.
  • I'm part of the Disability & Benefits Experience team 2 (aka team crabs)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Prior to this change there were no states to represent this subsection of 'excluded' submissions
  • To verify these changes work, instantiate a Form526Submission object (easiest using RSpec and fatcories) and call the new state transition methods on them

What areas of the site does it impact?

This is not a veteran facing change. This data will only be added to the database via script; there is no automatic transitioning to these states

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@SamStuckey SamStuckey mentioned this pull request Apr 23, 2024
Closed
@va-vfs-bot va-vfs-bot temporarily deployed to dbx/80624-add-verbose-526-remediation-states/main/main April 23, 2024 12:50 Inactive
@SamStuckey SamStuckey force-pushed the dbx/80624-add-verbose-526-remediation-states branch from 7490405 to 8c09abd Compare April 23, 2024 16:33
@va-vfs-bot va-vfs-bot temporarily deployed to dbx/80624-add-verbose-526-remediation-states/main/main April 23, 2024 17:11 Inactive
@SamStuckey SamStuckey force-pushed the dbx/80624-add-verbose-526-remediation-states branch from 8c09abd to e1268ec Compare April 23, 2024 18:33
NB28VT
NB28VT previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@NB28VT NB28VT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to dbx/80624-add-verbose-526-remediation-states/main/main April 23, 2024 19:03 Inactive
tblackwe
tblackwe previously approved these changes Apr 23, 2024
View reviewed changes
freeheeling
freeheeling reviewed Apr 23, 2024
View reviewed changes
app/models/form526_submission.rb Outdated
# a judgement call on wether or not a submission is a 'perfect' duplicate.
#
# IF a submission is found to be an exact duplicate of another
# AND it's duplicate was previously submitted / remediated successfully
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's typo

freeheeling
freeheeling reviewed Apr 23, 2024
View reviewed changes
app/models/form526_submission.rb Outdated
@@ -78,6 +78,33 @@ class Form526Submission < ApplicationRecord
event :mark_as_unprocessable do
transitions to: :unprocessable
end

# A special state to indicate this was part of our remediation 'batching'
# process in 2023. These were handled manually and are distinct fom `in_remediation`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fom typo

freeheeling
freeheeling previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@freeheeling freeheeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to label with disability-compensation

freeheeling
freeheeling reviewed Apr 23, 2024
View reviewed changes
app/models/form526_submission.rb Outdated
# Duplicates are identified by comparing form_json, using this script:
# https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/teams/benefits/scripts/526/submission_deduper.rb
# The result of this script can be evaluated by a qualified stakeholder to make
# a judgement call on wether or not a submission is a 'perfect' duplicate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wether typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna get a VIM spellchecker 😓 lol ty as always

@SamStuckey SamStuckey added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels Apr 23, 2024
@SamStuckey SamStuckey dismissed stale reviews from freeheeling, tblackwe, and NB28VT via ca10d1e April 23, 2024 19:44
@SamStuckey SamStuckey marked this pull request as ready for review April 24, 2024 12:02
@SamStuckey SamStuckey requested review from a team as code owners April 24, 2024 12:08
rmtolmach
rmtolmach approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

@SamStuckey SamStuckey merged commit 994c71f into master Apr 24, 2024
22 checks passed
@SamStuckey SamStuckey deleted the dbx/80624-add-verbose-526-remediation-states branch April 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblackwe tblackwe tblackwe approved these changes

@rmtolmach rmtolmach rmtolmach approved these changes

@freeheeling freeheeling freeheeling approved these changes

@NB28VT NB28VT NB28VT left review comments

Assignees
No one assigned
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SamStuckey @tblackwe @NB28VT @rmtolmach @freeheeling @va-vfs-bot