Simple Forms: Track users in 20-10207 #16456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thrillberg
force-pushed
the
20-10207-track-user
branch
from
4c944a9
to
2948a6d
Compare
rhasselle-oddball
approved these changes
Apr 23, 2024
| @@ -97,7 +98,11 @@ def submission_date_stamps | |||
| [] | |||
| end | |||
|
|
|||
| def track_user_identity(confirmation_number); end | |||
| def track_user_identity(confirmation_number) | |||
| identity = "#{data['preparer_type']} #{data['third_party_type']}" | |||
There was a problem hiding this comment.
is there any possibility of these being undefined?
There was a problem hiding this comment.
Yes third party type can be nil but that would stringify to "". As long as we're not calling a method on nil itself, it should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements user tracking for simple forms 20-10207.
Related issue(s)
https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/1234