80453 pt2 rehydrate 5655 controller #16459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amponce
reviewed
Apr 23, 2024
| def rehydrate | ||
| submission_id = params[:submission_id] | ||
|
|
||
| DebtsApi::V0::FsrRehydrationService.attempt_rehydration(user_uuid: current_user.uuid, submission_id:) |
There was a problem hiding this comment.
Is submission_id: missing a value?
There was a problem hiding this comment.
Nope! Ruby has a fun little bit of syntactic sugar where you don't need to specify a value for hash key-value pairs if the key and value are the same. In this case line 33 defines submission_id in scope so we don't need to specify submission_id: submission_id. If you want to make doubly sure that it works, check out modules/debts_api/spec/request/debts_api/v0/financial_status_reports_controller_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're exposing api endpoints to allow the frontend to rehydrate a form for a previously submitted FSR.
Related issue(s)
Testing done
Specs added.
What areas of the site does it impact?
Will eventually impact the FSR and debt portal. Currently these endpoints are used by nobody.
Acceptance criteria
Rehydrate endpoint only allows a user to rehydrate InProgressForm for their submissions.