Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE | Ask Va Api: Fix Inquiry Submit bug #16466

Merged
merged 1 commit into from
Apr 23, 2024
Merged

BE | Ask Va Api: Fix Inquiry Submit bug #16466

merged 1 commit into from
Apr 23, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • Updated Inquiries::Creator
    • Remove params key from payload
  • Add in missing params in inquiry_params

Related issue(s)

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

Update Inquiries::Creator and InquiriesController
c1a1046 
- Updated `inquiry_params`
- Fix argumet in `Inquiries::Creator`
@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this Apr 23, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners April 23, 2024 17:48
hemeshvpatel
hemeshvpatel approved these changes Apr 23, 2024
View reviewed changes
Copy link

@hemeshvpatel hemeshvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 116d8c7 into master Apr 23, 2024
23 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-fix-inquiry-submit-bug branch April 23, 2024 18:36
ericboehs pushed a commit that referenced this pull request Apr 26, 2024
@Khoa-V-Nguyen @ericboehs
Update Inquiries::Creator and InquiriesController (#16466)
33ca5ff 
- Updated `inquiry_params`
- Fix argumet in `Inquiries::Creator`

Co-authored-by: khoa-v-nguyen <khoa.nguyen@oddball.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemeshvpatel hemeshvpatel hemeshvpatel approved these changes

Assignees

@Khoa-V-Nguyen Khoa-V-Nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Khoa-V-Nguyen @hemeshvpatel @va-vfs-bot