Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manila timezone info logging #16468

Merged
merged 2 commits into from
Apr 24, 2024
Merged

manila timezone info logging #16468

merged 2 commits into from
Apr 24, 2024

Conversation

cferris32
Copy link
Contributor

Summary

  • This work is to implement investigative logging into the timezone info returned for the Manila, Philippines facility location

Testing Done

  • New test to verify logging functionality, ran regression tests on preexisting functionality

@cferris32 cferris32 requested review from a team as code owners April 23, 2024 19:07
jperk51
jperk51 requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jperk51 jperk51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be interested in logging the outcome of convert_utc_to_local_time(appt[:start], facility_timezone)

@va-vfs-bot va-vfs-bot temporarily deployed to manila_timezone_logging/main/main April 23, 2024 19:54 Inactive
@cferris32 cferris32 requested a review from jperk51 April 23, 2024 20:49
@cferris32
Copy link
Contributor Author

I would also be interested in logging the outcome of convert_utc_to_local_time(appt[:start], facility_timezone)

This should be addressed now

rmtolmach
rmtolmach reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but you probably want someone from @department-of-veterans-affairs/vfs-vaos to review since they're the primary codeowners of both files in this PR.

@cferris32 cferris32 merged commit da4c68f into master Apr 24, 2024
22 checks passed
@cferris32 cferris32 deleted the manila_timezone_logging branch April 24, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmtolmach rmtolmach rmtolmach left review comments

@jperk51 jperk51 jperk51 approved these changes

@simiadebowale simiadebowale simiadebowale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cferris32 @rmtolmach @jperk51 @simiadebowale @va-vfs-bot