Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-57328/update-sort-options #16474

Merged
merged 20 commits into from
May 6, 2024
Merged

Conversation

agravell047
Copy link
Contributor

@agravell047 agravell047 commented Apr 24, 2024

Summary

Created a generic sorting function to handle all sorting of medications for any number of sort options

Related issue(s)

https://jira.devops.va.gov/browse/MHV-57328

Sort criteria:

  1. (Default) Sorted Alphabetically by Status > Alphabetical > Last Fill Date: * This is the default sorting option that users will encounter upon accessing their medication list.
    Medications will be sorted alphabetically by their status (e.g., Active; Active: Refill in process; Active: Submitted, etc.)
    Then, within each status grouping, they will be sorted alphabetically by medication name.
    Then, within each alphabetical grouping, medications will be arranged based on their last fill date in descending order (newest to oldest).
  1. Sorted by Last Fill Date (New to Old) > Alphabetical: * Medications will be listed in descending order of last fill date (newest to oldest).
    Then, within the same fill date, they will be sorted alphabetically by medication name.
  1. Sorted Alphabetically by Medication Name > Last Fill Date (New to Old): * Medications will be sorted alphabetically by their names.
    Then, within the same alphabetical grouping, they will be further sorted based on their last fill date in descending order (newest to oldest).

Testing done

  • Tested locally
  • Updated VCR tests
  • Ran VCR tests

Screenshots

None

What areas of the site does it impact?

MHV medications app

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@agravell047 agravell047 changed the title Mhv 57328/update sort options Mhv 57328/update-sort-options Apr 24, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main April 24, 2024 14:10 Inactive
@agravell047 agravell047 changed the title Mhv 57328/update-sort-options MHV-57328/update-sort-options Apr 24, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main April 24, 2024 16:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main April 24, 2024 19:12 Inactive
@agravell047 agravell047 marked this pull request as ready for review April 24, 2024 20:07
@agravell047 agravell047 requested review from a team as code owners April 24, 2024 20:07
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main April 24, 2024 21:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main April 25, 2024 15:16 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main May 2, 2024 19:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main May 2, 2024 19:48 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main May 3, 2024 12:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main May 3, 2024 13:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-57328/update-sort-options/MHV-57328/update-sort-options/main May 3, 2024 14:15 Inactive
@agravell047 agravell047 merged commit 0b24099 into master May 6, 2024
18 of 19 checks passed
@agravell047 agravell047 deleted the MHV-57328/update-sort-options branch May 6, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants