Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE | Ask Va Api: Update Correspondences::Retriever and Inquiries::Retriever #16510

Merged
merged 2 commits into from
Apr 25, 2024
Merged

BE | Ask Va Api: Update Correspondences::Retriever and Inquiries::Retriever #16510

merged 2 commits into from
Apr 25, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • This PR introduce a fix for Inquiries::Retriever.
    • The class was failing due to Correspondences::Retriever erroring.

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

Update Correspondences::Retriever and Inquiries::Retriever
bca923b 
- `Inquiries::Retriever` is returning `correspondences` as an empty array
  instead of `erroring`
- clean up specs as well
@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this Apr 25, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners April 25, 2024 21:08
@Khoa-V-Nguyen Khoa-V-Nguyen enabled auto-merge (squash) April 25, 2024 21:13
hemeshvpatel
hemeshvpatel approved these changes Apr 25, 2024
View reviewed changes
Copy link

@hemeshvpatel hemeshvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["Looks good to me"]

@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 15552a8 into master Apr 25, 2024
20 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-inquiries-show-endpoint-bug branch April 25, 2024 21:18
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number-migrations
84e8fea 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
gabezurita added a commit that referenced this pull request Apr 25, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
069b04b 
* master:
  BE | Ask Va Api: Update `Correspondences::Retriever` and `Inquiries::Retriever` (#16510)
  Revert "post database updates (#16500)" (#16507)
  Revert "creates data to seed dev & staging (#16502)" (#16506)
  81092: Refactor Client Config Memoization (#16490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemeshvpatel hemeshvpatel hemeshvpatel approved these changes

Assignees

@Khoa-V-Nguyen Khoa-V-Nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Khoa-V-Nguyen @hemeshvpatel