Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support new gibft schema keys #2941

Merged
merged 3 commits into from Apr 10, 2019
Merged

support new gibft schema keys #2941

merged 3 commits into from Apr 10, 2019

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Apr 9, 2019 •
edited

Description of change

https://github.com/department-of-veterans-affairs/vets.gov-team/issues/17611
support new camelcase schema keys

Testing done

automated tests

Testing planned

test in staging

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@lihanli lihanli merged commit 6a08e68 into master Apr 10, 2019
@lihanli lihanli deleted the gibft-new-schema branch April 10, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kreek kreek kreek approved these changes

@jholton jholton jholton approved these changes

@hpjaj hpjaj hpjaj approved these changes

@kfrz kfrz kfrz approved these changes

@egarreau egarreau Awaiting requested review from egarreau

@SMLuthi SMLuthi Awaiting requested review from SMLuthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lihanli @kreek @jholton @hpjaj @kfrz @va-vfs-bot