Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log vet360 request bodies #3183

Merged
merged 3 commits into from Aug 1, 2019
Merged

log vet360 request bodies #3183

merged 3 commits into from Aug 1, 2019

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Jul 29, 2019

Description of change

we're seeing errors with the vets360 api possibly related to the effective_start_date attribute, we should log the requests to help figure out what is causing these errors

Testing done

automated tests

Testing planned

test in staging

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to log-v360-reqs/master July 29, 2019 18:29 Inactive
@lihanli lihanli requested a review from a team July 29, 2019 18:38
Copy link
Contributor

@annaswims annaswims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a whole lot of PII to be logging. Could we log just the few attributes we're interested in?

@kfrz
Copy link
Contributor

kfrz commented Jul 29, 2019

Is there no way to recreate this in a lower environment or on the command line rather than capturing all the body? Is there an associated issue or further details?

@lihanli
Copy link
Contributor Author

lihanli commented Jul 31, 2019

@kfrz here's the issue for the error https://github.com/department-of-veterans-affairs/vets.gov-team/issues/19386

i tried to recreate the error in console but it didn't work (the request succeeded and returned 200)

@lihanli
Copy link
Contributor Author

lihanli commented Jul 31, 2019

@annaswims i changed it to only log the dates

@va-vfs-bot va-vfs-bot temporarily deployed to log-v360-reqs/master July 31, 2019 00:28 Inactive
Copy link
Contributor

@annaswims annaswims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants