Updated 2122 JSON Schema based on Fillable PDF #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-api into bastosmichael/2122-schema-update
…ts-api into bastosmichael/2122-schema-update
bastosmichael
requested review from
omgitsbillryan
and removed request for
a team
omgitsbillryan
approved these changes
Jun 4, 2020
bastosmichael
added a commit
that referenced
this pull request
Jul 16, 2020
* Updated 2122 JSON Schema based on Fillable PDF (#4356) * Updated 2122 JSON Schema based on Fillable PDF * Revert "Send evss source in claims (#4317)" (#4352) This reverts commit 21f3a8e. * last form parts * update POA schema for camelCase * fix failing POA tests Co-authored-by: Charley Stran <charley.stran@gmail.com> * add signature PDF's json schema to 2122 payload (#4357) * add signature PDF's to 2122 payload * removing spec accidentally added from other branch * fix the cops * Insert 2122 signatures (#4428) * add signature PDF's to 2122 payload * removing spec accidentally added from other branch * fix the cops * adding base64 image to 2122 request * 2122 sign the pdf page 1 * singing both PDF's and merging them for 2122 * fill and sign page one of 2122 * page 2 pdf filling * nest address properties * finalizing the specs for 2122 pdf generation * add some error tracking on bad images * Apply suggestions from code review JSON updated suggested by @ed Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com> * Apply suggestions from code review More JSON changes from @ed Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com> * remove unneeeded files * updates to schema * revert schema changes * refactor the vbms uploader * update the specs * custom rspec matcher * updates for rubocop * update migration to make it reversible * Ordering kwargs * 2122 signature doc updates (#4414) * update 2122 form swagger * Add example 2122 json example * rubo changes * 9365 va file number endpoint (#4331) * update fixture * remove bad file * [10403] 422 No Supplies Selected Error Handling & 503 Service Unavailable Error Handling (#4410) * supplies not selected * change invalid to 404 * add 503 check * added service_unavailable exception * fix client error status code * fix invalid order test * test fix * add get_supplies_503 spec * test fix * test fix Co-authored-by: Derek Dyer <derek@digitalderek.com> Co-authored-by: Cameron Testerman <cameronbtesterman@gmail.com> * remove unneeded lines from stamp error * moving the call of when to build 2122 with sig to create over upload Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com> Co-authored-by: Derek Dyer <derek@digitalderek.com> Co-authored-by: Cameron Testerman <cameronbtesterman@gmail.com> * refactored vbms jobs * moved rescues to the perform methods of the jobs themselves. * add Digital Signature for 21-22 paragraph (#4495) * use newly renamed bgs gem (#4445) * use newly renamed bgs gem * update bgs version * update to latest BGS gem * STEM: Update form 22-10203 submission. #7857 (#4483) * Update Gemfile.lock * Update education_facility.rb * cleanup special cases * Remove NewRelic gem and config (#4484) * use Caseflow-style field names (add reference back to id fields) (#4481) * EDU: Add EDU users to staging YTD report distribution #10970 (#4489) * add email address for staging * Update spool_submissions_report_mailer_spec.rb * YTD, not spool * use lowercase camelCase for JSON:API datatypes (#4472) * use lowercase camelCase for JSONAPI datatypes * Update higher_level_reviews_controller_swagger.rb * typo * use higherLevelReview instead of higherLevelReviewInfo. camelCase fields in show response * fix typo * Attach Veteran's Status to 10-10CG Submissions (#4486) * disable tests and return emis search results for testing on Review Instance. * disable swagger spec * enable specs, remove error raise in Form1010cg::Service#is_veteran on eMIS 400s * Update spec/services/form1010cg/service_spec.rb * Add veteran status lookup to Form1010cg claim processing * use soft get (&) rather than #try for eMIS lookup in Form1010cg::Service * render backend service outage on invalid vet status for Form1010cg submission (#4487) * BDD: Fix Form Mapping (#4491) * add 526 bdd mapping * first try at test * comment out incomplete test * do tests pass * wrote spec Co-authored-by: Anna Carey <anna@adhocteam.us> Co-authored-by: Sarah-Jaine Szekeresh <sarah-jaine@adhocteam.us> * VAOS + FHIR - Search Patient Resource (Collection) (#4343) * fhir patient search controller, specs and cassettes written * Send PDF to CARMA (#4475) * Allow CaregiverAssistanceClaims to generate a PDF now. * Create DB table form_1010_cg_submissions, add index for carma_case_id, make Form1010cg::Submission an ActiveRecord Model, save the caregivers assistance claim. Update Form1010cg::Service to require a saved claim. Add placeholder methods for post submission processing. Add a CARMA::Models::Attachment Model, add specs for the model. * Make CARMA::Models::Attachment submittable, refactor constants, add #submit * remove #client from CARMA::Models::Base. Add #client to CARMA::Models::Base. Update Submission spec - stub to_request_payload * Add methods for submitting attachment for CARMA::Client * associate SavedClaim::CaregiversAssistanceClaim to Form1010cg::Submission (as has many), add #submitted? method to CaregiversAssistanceClaim, add Form1010cg::Submission factroy bot. * Add #submit_attachment to Form1010cg::Service * remove saving claim and Form1010cg::Submission AR model functionality * Add CARMA::Models::Attachments and relates spec * Add #upload_attachments and #upload_attachments_stub to CARMA::Client * Add #submit_attachments! to Form1010cg::Service * restyle variable * add #to_h to CARMA Attachment and Attachments, update the Form1010cg::Submission attachments after upload. Update CARMA::Client to use one oauth request * Fix bad const reference in Form1010cg::Service * Add and slit up CARMA VCR Cassettes. Convert CARMA::Client::Client to Singlton, update CARMA Model reference to the CARMA client. Add request specs for :stub_carma_responses feature flipper, update VCRs used, add more strict cassette matching criteria. Try to submit attachment in Form1010cg::Service without raising error. * Update tests that reference CARMA::Client to use singlton instance * Fix specs. update Carma::Models::Attachments#to_h * cleanup * remove schema changes (manually since migration was removed) * Use claim guid as filename for PDF * Soft fail 10-10CG attachment being sent to CARMA in Form1010cg::Service. Rename Form1010cg::Service#submit_attachments! to Form1010cg::Service#submit_attachment. * Update spec/models/saved_claim_spec.rb * Fix spelling on arg * Update CARMA lib docs * Update CARMA lib docs * Rename #to_h to #to_hash for CARMA::Models::Attachment(s) * Update comments for CARMA::Client::Client and Sending Attachments to CARMA * typo * Add HLR feature flag (#4490) * Appeals API - nest /contestable_issues under /higher_level_reviews (#4471) * nest contestable_issues * let Caseflow 4XX errors passthrough for /contestable_issues * rubocop * rubocop * typo * tweak cassettes * more tests * Update higher_level_reviews_controller_swagger.rb * add test for codeclimate coverage req * fix documentation to reflect caseflow change (no longer returning SSN in error responses) * fix path for betamocks * Just renaming the gem repo in final renaming step (#4493) * add Digital Signature for 21-22 paragraph @darduda 's suggested changes * add POST Co-authored-by: Charley Stran <charley.stran@oddball.io> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: John Paul Ashenfelter <johnpaulashenfelter@users.noreply.github.com> Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com> Co-authored-by: Kevin Mircovich <kmircovich1@gmail.com> Co-authored-by: Sarah-Jaine Szekeresh <SarahJaine@users.noreply.github.com> Co-authored-by: Anna Carey <anna@adhocteam.us> Co-authored-by: Sarah-Jaine Szekeresh <sarah-jaine@adhocteam.us> Co-authored-by: AJ Magdub <ahmed.magdub@va.gov> Co-authored-by: Rob Garrison <wowmotty@gmail.com> Co-authored-by: Michael Bastos <bastosmichael@gmail.com> * updating schema * rubocop fix * added required field * fixing merge conflicts Co-authored-by: Charley Stran <charley.stran@gmail.com> Co-authored-by: Charley Stran <charley.stran@oddball.io> Co-authored-by: Ed Mangimelli <38672641+edmangimelli@users.noreply.github.com> Co-authored-by: Derek Dyer <derek@digitalderek.com> Co-authored-by: Cameron Testerman <cameronbtesterman@gmail.com> Co-authored-by: Ryan Link <47920994+ryanlink@users.noreply.github.com> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: John Paul Ashenfelter <johnpaulashenfelter@users.noreply.github.com> Co-authored-by: Kevin Mircovich <kmircovich1@gmail.com> Co-authored-by: Sarah-Jaine Szekeresh <SarahJaine@users.noreply.github.com> Co-authored-by: Anna Carey <anna@adhocteam.us> Co-authored-by: Sarah-Jaine Szekeresh <sarah-jaine@adhocteam.us> Co-authored-by: AJ Magdub <ahmed.magdub@va.gov> Co-authored-by: Rob Garrison <wowmotty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add all of the additional form fields to the JSON Payload from pdf https://www.vba.va.gov/pubs/forms/VBA-21-22-ARE.pdf
Original issue(s)
https://vajira.max.gov/browse/API-905
Things to know about this PR