Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exceptions phase 3 #585

Merged
merged 32 commits into from Dec 12, 2016
Merged

Refactor exceptions phase 3 #585

merged 32 commits into from Dec 12, 2016

Commits on Nov 30, 2016

  1. temporary commit

    @saneshark
    saneshark committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    cbda8f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/department-of-veterans-af… 

    …fairs/vets-api
    @saneshark
    saneshark committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    9866776 View commit details
    Browse the repository at this point in the history

  3. add a route for simulating a 500 test available in production

    @saneshark
    saneshark committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    8e3bc64 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2016

  1. accidental commit

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    66d4fa5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into refactor_exceptions_phase_3

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    90be33e View commit details
    Browse the repository at this point in the history

  3. initial commit of backend_service_exception DSL changes

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    61f753e View commit details
    Browse the repository at this point in the history

  4. fixing one spec

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    24592ae View commit details
    Browse the repository at this point in the history

  5. minor change to ensure status and source are set if available

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    c0d3801 View commit details
    Browse the repository at this point in the history

  6. fixes to suppoer breakers integration

    @saneshark
    saneshark committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    143d26e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2016

  1. changes to fix multi_client spec failing

    @saneshark
    saneshark committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    283f094 View commit details
    Browse the repository at this point in the history

  2. upmerged fixed conflict in multi_client

    @saneshark
    saneshark committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    b794e0d View commit details
    Browse the repository at this point in the history

  3. bumping rubocop linelength metric from 120 to 140

    @saneshark
    saneshark committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    3c24f9d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2016

  1. rollback rubocop changes

    @saneshark
    saneshark committed Dec 5, 2016
    Configuration menu
    Copy the full SHA
    c6404e7 View commit details
    Browse the repository at this point in the history

  2. add disable line length and new rubocop rules for conditionals

    @saneshark
    saneshark committed Dec 5, 2016
    Configuration menu
    Copy the full SHA
    52fc71e View commit details
    Browse the repository at this point in the history

  3. rollback changes to messages_controller

    @saneshark
    saneshark committed Dec 5, 2016
    Configuration menu
    Copy the full SHA
    3bd2fd0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. various changes

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    c4ba726 View commit details
    Browse the repository at this point in the history

  2. moved normalization of errors into its own middleware

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    8bf9f3c View commit details
    Browse the repository at this point in the history

  3. minor change

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    fde6d96 View commit details
    Browse the repository at this point in the history

  4. minor changes

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    a918659 View commit details
    Browse the repository at this point in the history

  5. these rubocop changes can go in a different PR

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    f8b837d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into refactor_exceptions_phase_3

    @saneshark
    saneshark committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    7a0ff59 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2016

  1. add warning message about error not being mapped in locales

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    0216191 View commit details
    Browse the repository at this point in the history

  2. fix message for source

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    3bb83aa View commit details
    Browse the repository at this point in the history

  3. cleanup some separation of concerns

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    d0758d4 View commit details
    Browse the repository at this point in the history

  4. renaming method to be more self explanatory

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    80c2877 View commit details
    Browse the repository at this point in the history

  5. dry up some of the breakers integration for configuration.rb

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    a3619c5 View commit details
    Browse the repository at this point in the history

  6. improve comment

    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    7918e2c View commit details
    Browse the repository at this point in the history

  7. ensure backend service exception works with breakers, might revisit l… 

    …ater
    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    0bbffbe View commit details
    Browse the repository at this point in the history

  8. for now let backend exception handle 400..599, in the future this wil… 

    …l be limited
    @saneshark
    saneshark committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    06bda2f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2016

  1. Merge branch 'master' into refactor_exceptions_phase_3

    @saneshark
    saneshark committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    8588b01 View commit details
    Browse the repository at this point in the history

  2. making changes per code review

    @saneshark
    saneshark committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    73a31cb View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2016

  1. Merge branch 'master' into refactor_exceptions_phase_3

    @saneshark
    saneshark committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    15ccd3b View commit details
    Browse the repository at this point in the history