Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rswag dependencies to explicit subdivided gems #7302

Merged
merged 1 commit into from Jun 24, 2021

Conversation

hinzed1127
Copy link
Contributor

Rswag seems to have an issue where it implicitly requires rspec-core. This isn't currently in our higher environments.

Description of change

Original issue(s)

https://vajira.max.gov/browse/API-7861

Things to know about this PR

  • ran rake rswag:specs:swaggerize command locally to ensure dependencies are met
  • navigated to http://localhost:3000/services/claims/docs/swagger/index.html locally to ensure dependencies are met for swagger ui
  • these are the only 2 use cases we require of rswag currently, so splitting them into their separate gems of rswag-ui and rswag-specs seems appropriate (we have no need for the rswag-api gem bundled along with rswag)

@hinzed1127 hinzed1127 requested a review from jw81 June 24, 2021 21:30
@hinzed1127 hinzed1127 requested review from a team as code owners June 24, 2021 21:30
@hinzed1127 hinzed1127 changed the title Update rswag dependencies Update rswag dependencies to explicit subdivided gems Jun 24, 2021
@hinzed1127 hinzed1127 merged commit 72453d4 into master Jun 24, 2021
@hinzed1127 hinzed1127 deleted the dh-api-7861-addendum branch June 24, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants