exploding va_rx gem into vets-api -- with minor refactor #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # FIXME: Add this spec | ||
| describe Common::Base do | ||
| end |
There was a problem hiding this comment.
did you forget to do this or are you going to add it in another pr?
There was a problem hiding this comment.
it will be in a separate PR. Currently have close to 100% coverage, but it's based off of Prescriptions. I think it should be more generic than that, but didn't want to spend umpteen hours rewriting specs when it's already at 100%
|
Other than @lihanli 's comment LGTM |
|
👍 |
| def <=>(other) | ||
| return -1 if prescription_id < other.prescription_id | ||
| return 1 if prescription_id > other.prescription_id | ||
| 0 |
There was a problem hiding this comment.
Can this be shortened to prescription_id <=> other.prescription_id?
There was a problem hiding this comment.
maybe... (it should) let me test that out really quick -- will make similar change for tracking if its the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.