Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation: Root font-size rem value migration #2431

Closed
2 tasks
micahchiang opened this issue Jan 29, 2024 · 1 comment
Closed
2 tasks

Formation Deprecation: Root font-size rem value migration #2431

micahchiang opened this issue Jan 29, 2024 · 1 comment
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

After completing the discovery work on migrating the base font size,we have decided to migrate root font size globally.

There is some related work done already for this:

Confluence document:

Global approach code examples:

Tasks

  • migrate font size

Acceptance Criteria

  • Font size has been migrated globally in vets-website, formation, and content build
@micahchiang micahchiang added dst-engineering Issues that require work from Design System Team engineers platform-design-system-team labels Jan 29, 2024
@micahchiang micahchiang self-assigned this Jan 29, 2024
@micahchiang micahchiang transferred this issue from department-of-veterans-affairs/va.gov-team Jan 29, 2024
@rmessina1010 rmessina1010 self-assigned this Feb 1, 2024
@rmessina1010
Copy link
Contributor

Created overrides files for Formation, and applied conversion utilities;

  • note: still importing burbon from uswds, this is intentional, as it imports uswds utilities, but had no rem changes of note;
  • pending: convert arbitrary px values

Ready for test/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

2 participants