Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Typography base size migration QA Formation #2494

Closed
4 tasks
micahchiang opened this issue Feb 12, 2024 · 4 comments
Closed
4 tasks
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

With the completion of #2431, thorough QA needs to be conducted in vets-website prior to any pull request being merged in. This likely means local testing with verdaccio and sandbox testing with the preview instance that gets generated when a pull request is submitted to vets-website and content-build

Considerations

  • Pull request into formation. This should ultimately bump the version number for Formation as well.
  • Pull request into vets-website. This should include the version change from the above PR, and QA should be conducted using the preview instance and/or verdaccio.

Tasks

  • Submit PR into content-build and conduct QA
  • Conduct QA on vets-website PR above
  • Address any visual issues in Formation

Acceptance Criteria

  • Above tasks have been completed
@caw310
Copy link
Contributor

caw310 commented Feb 12, 2024

@caw310 caw310 added Stretch Stretch goals dst-engineering Issues that require work from Design System Team engineers labels Feb 12, 2024
@jamigibbs
Copy link
Contributor

@micahchiang There might be something in progress already for this but have we started also converting any existing rem values in individual apps yet? Would that need to be part of this vets-website pr too?

@micahchiang
Copy link
Contributor Author

@jamigibbs - Good call out. Yes, that would need to be part of the vets-website PR.

@powellkerry
Copy link
Contributor

This will carry over due to complexity and dependencies with the other Typography tickets. It is taking a while to QA and figure out where defects should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

7 participants