Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Global Updates: Base font-size change from 10px to 16px #26606

Open
wants to merge 125 commits into
base: main
Choose a base branch
from

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Nov 7, 2023

Summary

This is a collaborative PR by the @department-of-veterans-affairs/platform-design-system-fe team

The global base font-size is being changed from 10px to 16px. This is to align VA.gov with USWDS standards. There should be no visual changes observed from this update.

Changes incorporated into this PR:

  • Base font-size change in @department-of-veterans-affairs/formation as well as font adjustments to base css classes and typography.
  • Font-size, spacing, and sizing adjustments and DST components (@department-of-veterans-affairs/component-library)
  • Font-size, spacing, and typography adjustment in css-library (@department-of-veterans-affairs/css-library)
  • Cursory adjustments found through local testing to vets-website, content-build, and vagov-content

**Because of the global nature of these changes we anticipate that teams will need to check their applications. These changes will affect any rem values used in font-size, spacing, and sizing. Jami Gibbs has developed a tool to determine equivalent rem values here: https://jamigibbs.github.io/rem-to-rem/

Additional Related PR

Content Build

We are aware that there are a few global elements that are displaying larger than intended in this PR. The reason is that there is a separate Content Build PR that will address those changes.

For example, we are aware of the Feedback button displaying larger than it should. There is no need to comment on that in this PR.

Screenshot 2024-05-13 at 11 20 26 AM

Related issue(s)

Related app specific issues

Testing done

Local testing has been done on un-authenticated pages. Further testing will be done through the review instance. Individual teams are expected to QA their application.

What areas of the site does it impact?

This will impact all areas of the site where rem values are used.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main November 7, 2023 17:43 Inactive
@jamigibbs jamigibbs changed the title Formation Global Updates: Add overrides for uswds imports in minimal stylesheet Formation Global Updates: Font-size overrides for USWDS v3 preparation Nov 7, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main January 26, 2024 02:12 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main January 26, 2024 21:51 Inactive
@jamigibbs jamigibbs changed the title Formation Global Updates: Font-size overrides for USWDS v3 preparation Formation Global Updates: Font-size overrides for minimal stylesheet Jan 29, 2024
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main March 7, 2024 23:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main March 8, 2024 16:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main March 11, 2024 20:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main March 13, 2024 15:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 13, 2024 19:27 Inactive
Mottie
Mottie previously approved these changes May 13, 2024
dcloud
dcloud previously requested changes May 13, 2024
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing /my-health/ on behalf of @department-of-veterans-affairs/vfs-mhv-integration:

Changes to MHV Secondary Nav needed, per this PR: /pull/29750

Changes to src/applications/mhv-landing-page/sass/mhv-landing-page.scss look correct according to the visual diff I performed. Also the math looks correct: 10*1 == 10 --> 16*0.625 == 10, etc.

@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 13, 2024 23:59 Inactive
dcloud
dcloud previously approved these changes May 14, 2024
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing /my-health/ on behalf of @department-of-veterans-affairs/vfs-mhv-integration:

Changes for /my-health/ and secondary nav look good

@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 14, 2024 14:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 14, 2024 23:48 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 15, 2024 16:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/66753-formation-global-overrides/main May 15, 2024 18:47 Inactive
robertbylight and others added 3 commits May 15, 2024 13:17
* Fix save-in-progress alert title

* Fix downtime alert headers

* Add & update unit tests

* Add appeals downtime e2e tests

* Add missing formConfig

* Add customText to facility locator

* inject axe before check

* Update check-in appType
* MHV-58050: Chem/hem content updates

* MHV-58050: UCD validation feedback updates

* MHV-58050: Unit tests written

* MHV-58050: Cypress test fixed

---------

Co-authored-by: Matthew Wright <matwright2010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet