New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formation Global Updates: Base font-size change from 10px to 16px #26606
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
…nd facility locator search button width
ef2ded1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing /my-health/
on behalf of @department-of-veterans-affairs/vfs-mhv-integration:
Changes to MHV Secondary Nav needed, per this PR: /pull/29750
Changes to src/applications/mhv-landing-page/sass/mhv-landing-page.scss
look correct according to the visual diff I performed. Also the math looks correct: 10*1 == 10 --> 16*0.625 == 10
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing /my-health/
on behalf of @department-of-veterans-affairs/vfs-mhv-integration:
Changes for /my-health/
and secondary nav look good
* Fix save-in-progress alert title * Fix downtime alert headers * Add & update unit tests * Add appeals downtime e2e tests * Add missing formConfig * Add customText to facility locator * inject axe before check * Update check-in appType
* MHV-58050: Chem/hem content updates * MHV-58050: UCD validation feedback updates * MHV-58050: Unit tests written * MHV-58050: Cypress test fixed --------- Co-authored-by: Matthew Wright <matwright2010@gmail.com>
Summary
This is a collaborative PR by the @department-of-veterans-affairs/platform-design-system-fe team
The global base font-size is being changed from 10px to 16px. This is to align VA.gov with USWDS standards. There should be no visual changes observed from this update.
Changes incorporated into this PR:
**Because of the global nature of these changes we anticipate that teams will need to check their applications. These changes will affect any
rem
values used in font-size, spacing, and sizing. Jami Gibbs has developed a tool to determine equivalentrem
values here: https://jamigibbs.github.io/rem-to-rem/Additional Related PR
Content Build
We are aware that there are a few global elements that are displaying larger than intended in this PR. The reason is that there is a separate Content Build PR that will address those changes.
For example, we are aware of the Feedback button displaying larger than it should. There is no need to comment on that in this PR.
Related issue(s)
Related app specific issues
Testing done
Local testing has been done on un-authenticated pages. Further testing will be done through the review instance. Individual teams are expected to QA their application.
What areas of the site does it impact?
This will impact all areas of the site where
rem
values are used.Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?