Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Migrate font settings from Formation to CSS Library #2537

Closed
2 tasks
micahchiang opened this issue Feb 26, 2024 · 2 comments
Closed
2 tasks
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

Once QA on our font settings has been conducted in #2494 and #2525, we need to add the converted typography styles to CSS Library.

Considerations

  • Formation PR
  • Structure: For now, we can probably port things over in the structure they are in currently.
    • formation modules -> css library modules
    • formation elements -> css library elements
    • formation components -> css library components etc
  • Our main goal here is to just get the styles into css library, and worry about swapping them out later (ticket to come). Ideally, we want to bring them over in a way that creates the least amount of chaos when we attempt to replace the imports for these in vets-website from Formation to CSS Library.

Tasks

  • Copy all necessary styles from Formation to CSS Library

Acceptance Criteria

  • Above tasks have been completed
@caw310
Copy link
Contributor

caw310 commented Feb 28, 2024

@jamigibbs
Copy link
Contributor

jamigibbs commented Apr 24, 2024

The work done here generated a large PR that will have implications on how we move forward with the deprecation of Formation so we wanted to make sure there was dedicated time to review it collectively.

I have created this follow-up ticket #2768 for that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

3 participants