Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Typography base size migration QA vets-website, content-build and vagov-content #2525

Closed
5 tasks
micahchiang opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

micahchiang commented Feb 22, 2024

Description

With the completion of #2494 , thorough QA needs to be conducted in vets-website prior to any pull request being merged in. This likely means local testing and sandbox testing with the preview instance that gets generated when a pull request is submitted to vets-website and content-build

Considerations

  • Pull request into formation. This should ultimately bump the version number for Formation as well.
  • Pull request into vets-website. This should include the version change from the above PR, and QA should be conducted using the preview instance and/or verdaccio.

Tasks

  • Submit PR into content-build and conduct QA
  • Conduct QA on vets-website PR above
  • Scale any rem values applications are using with the rem override functions
  • Merge PRs into vets-website and content-build

Acceptance Criteria

  • Above tasks have been completed
@micahchiang micahchiang added platform-design-system-team dst-engineering Issues that require work from Design System Team engineers labels Feb 22, 2024
@micahchiang micahchiang changed the title Formation Deprecation - Typography base size migration QA vets-website Formation Deprecation - Typography base size migration QA vets-website and content-build Feb 22, 2024
@caw310
Copy link
Contributor

caw310 commented Feb 22, 2024

@powellkerry
Copy link
Contributor

content-build branch: 66753-formation-typography-updates

@powellkerry powellkerry changed the title Formation Deprecation - Typography base size migration QA vets-website and content-build Formation Deprecation - Typography base size migration QA vets-website, content-build and vagov-content Mar 12, 2024
@powellkerry
Copy link
Contributor

vagov-content branch: 66753-formation-base-font-bugs

@powellkerry
Copy link
Contributor

This ticket will not be completed by March 27th. The work should be completed within the next week. A seperate card will be created to merge this effort into vets-website after team approvals.

@harshil1793
Copy link
Contributor

This ticket was not completed because resolving the component-library took more time than expected. After creating a beta release and testing all the repositories consuming the component-library, we are currently facing a CI test failure that needs to be fixed to move ahead. Therefore, it's a carryover.

@powellkerry
Copy link
Contributor

Closing this ticket with a successful CI run in vets-website. This will be merged in upcoming work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Development

No branches or pull requests

5 participants