Revert "akshually ignore linter"

This reverts commit ffd7f76.
department-of-veterans-affairs · Mar 11, 2024 · dcb6cea · dcb6cea
1 parent ffd7f76
commit dcb6cea
Show file tree

Hide file tree

Showing 21 changed files with 534 additions and 465 deletions.
diff --git a/src/applications/ask-va/components/BreadCrumbs.jsx b/src/applications/ask-va/components/BreadCrumbs.jsx
@@ -17,7 +17,7 @@ const BreadCrumbs = ({ currentLocation }) => {
   const breadcrumbLinks = breadcrumbsDictionary[adjustedLocation];
 
   return (
-    <va-breadcrumbs uswds="false" label="Breadcrumbs">
+    <va-breadcrumbs label="Breadcrumbs">
       {breadcrumbLinks.map(link => (
         <a href={link.href} key={link.key}>
           {link.title}

diff --git a/src/applications/debt-letters/components/DebtDetails.jsx b/src/applications/debt-letters/components/DebtDetails.jsx
@@ -57,7 +57,7 @@ const DebtDetails = ({ selectedDebt, debts }) => {
 
   return (
     <div className="vads-u-display--flex vads-u-flex-direction--column">
-      <VaBreadcrumbs uswds="false" label="Breadcrumb">
+      <VaBreadcrumbs label="Breadcrumb">
         <a href="/">Home</a>
         <a href="/manage-va-debt">Manage your VA debt</a>
         <a href="/manage-va-debt/your-debt">Your VA debt</a>

diff --git a/src/applications/debt-letters/components/DebtLettersDownload.jsx b/src/applications/debt-letters/components/DebtLettersDownload.jsx
@@ -24,7 +24,7 @@ const DebtLettersDownload = ({
   return (
     <div className="vads-l-row large-screen:vads-u-margin-x--neg2p5">
       <div className="vads-u-font-family--sans">
-        <VaBreadcrumbs uswds="false" label="Breadcrumb">
+        <VaBreadcrumbs label="Breadcrumb">
           <a href="/">Home</a>
           <a href="/manage-va-debt">Manage your VA debt</a>
           <a href="/manage-va-debt/your-debt">Your debt</a>

diff --git a/src/applications/debt-letters/components/DebtLettersSummary.jsx b/src/applications/debt-letters/components/DebtLettersSummary.jsx
@@ -112,7 +112,7 @@ const DebtLettersSummary = ({ isError, isVBMSError, debts, debtLinks }) => {
 
   return (
     <>
-      <VaBreadcrumbs uswds="false" label="Breadcrumb">
+      <VaBreadcrumbs label="Breadcrumb">
         <a href="/">Home</a>
         <a href="/manage-va-debt">Manage your VA debt</a>
         <a href="/manage-va-debt/your-debt">Your VA debt</a>

diff --git a/src/applications/disability-benefits/2346/containers/App.jsx b/src/applications/disability-benefits/2346/containers/App.jsx
@@ -65,7 +65,7 @@ class App extends Component {
       <>
         {!featureToggles.loading && (
           <div className="large-screen:vads-u-padding-left--0 vads-u-padding-left--2">
-            <VaBreadcrumbs uswds="false" label="Breadcrumb">
+            <VaBreadcrumbs label="Breadcrumb">
               <a href="/">Home</a>
               {/* this will get updated when this route is added */}
               <a href="/health-care">Health care</a>
@@ -80,11 +80,13 @@ class App extends Component {
             Loading your information...
           </va-loading-indicator>
         )}
-        {isError && !pending && isLoggedIn && (
-          <div className="row vads-u-margin-bottom--3">
-            <ErrorMessage />
-          </div>
-        )}
+        {isError &&
+          !pending &&
+          isLoggedIn && (
+            <div className="row vads-u-margin-bottom--3">
+              <ErrorMessage />
+            </div>
+          )}
         {showMainContent && (
           <RoutedSavableApp formConfig={formConfig} currentLocation={location}>
             {children}
@@ -106,4 +108,7 @@ const mapDispatchToProps = dispatch => ({
   ...bindActionCreators({ fetchFormStatus }, dispatch),
 });
 
-export default connect(mapStateToProps, mapDispatchToProps)(App);
+export default connect(
+  mapStateToProps,
+  mapDispatchToProps,
+)(App);
diff --git a/src/applications/education-letters/components/Layout.jsx b/src/applications/education-letters/components/Layout.jsx
@@ -10,7 +10,7 @@ const Layout = ({ children, clsName = '', breadCrumbs = {} }) => {
 
   return (
     <>
-      <va-breadcrumbs uswds="false">
+      <va-breadcrumbs>
         <a href="/">Home</a>
         <a href="/education/">Education and training</a>
         {renderBreadCrumbs()}
@@ -29,9 +29,9 @@ const Layout = ({ children, clsName = '', breadCrumbs = {} }) => {
 };
 
 Layout.propTypes = {
-  breadCrumbs: PropTypes.object,
-  children: PropTypes.object,
   clsName: PropTypes.string,
+  children: PropTypes.object,
+  breadCrumbs: PropTypes.object,
 };
 
 export default Layout;
diff --git a/src/applications/enrollment-verification/components/EnrollmentVerificationBreadcrumbs.jsx b/src/applications/enrollment-verification/components/EnrollmentVerificationBreadcrumbs.jsx
@@ -52,5 +52,5 @@ export default function EnrollmentVerificationBreadcrumbs() {
     );
   }
 
-  return <va-breadcrumbs uswds="false">{breadcrumbs}</va-breadcrumbs>;
+  return <va-breadcrumbs>{breadcrumbs}</va-breadcrumbs>;
 }
diff --git a/src/applications/fry-dea/containers/FryDeaApp.jsx b/src/applications/fry-dea/containers/FryDeaApp.jsx
@@ -24,40 +24,43 @@ function FryDeaApp({
 }) {
   const [fetchedVeterans, setFetchedVeterans] = useState(false);
 
-  useEffect(() => {
-    if (!user.login.currentlyLoggedIn) {
-      return;
-    }
+  useEffect(
+    () => {
+      if (!user.login.currentlyLoggedIn) {
+        return;
+      }
 
-    if (!fetchedVeterans) {
-      setFetchedVeterans(true);
-      getVeterans();
-    }
+      if (!fetchedVeterans) {
+        setFetchedVeterans(true);
+        getVeterans();
+      }
 
-    if (
-      formData.showUpdatedFryDeaApp !== showUpdatedFryDeaApp ||
-      formData.veterans !== veterans
-    ) {
-      setFormData({
-        ...formData,
-        showUpdatedFryDeaApp,
-        veterans,
-      });
-    }
-  }, [
-    fetchedVeterans,
-    formData,
-    getVeterans,
-    location.pathname,
-    setFormData,
-    showUpdatedFryDeaApp,
-    user.login.currentlyLoggedIn,
-    veterans,
-  ]);
+      if (
+        formData.showUpdatedFryDeaApp !== showUpdatedFryDeaApp ||
+        formData.veterans !== veterans
+      ) {
+        setFormData({
+          ...formData,
+          showUpdatedFryDeaApp,
+          veterans,
+        });
+      }
+    },
+    [
+      fetchedVeterans,
+      formData,
+      getVeterans,
+      location.pathname,
+      setFormData,
+      showUpdatedFryDeaApp,
+      user.login.currentlyLoggedIn,
+      veterans,
+    ],
+  );
 
   return (
     <>
-      <va-breadcrumbs uswds="false">
+      <va-breadcrumbs>
         <a href="/">Home</a>
         <a href="/education">Education and training</a>
         <a href="/fry-dea">
@@ -95,4 +98,7 @@ const mapDispatchToProps = {
   getVeterans: fetchVeterans,
 };
 
-export default connect(mapStateToProps, mapDispatchToProps)(FryDeaApp);
+export default connect(
+  mapStateToProps,
+  mapDispatchToProps,
+)(FryDeaApp);
diff --git a/src/applications/gi/components/GiBillBreadcrumbs.jsx b/src/applications/gi/components/GiBillBreadcrumbs.jsx
@@ -47,7 +47,7 @@ const GiBillBreadcrumbs = () => {
     );
   }
 
-  return <VaBreadcrumbs uswds="false">{crumbs}</VaBreadcrumbs>;
+  return <VaBreadcrumbs>{crumbs}</VaBreadcrumbs>;
 };
 
 export default GiBillBreadcrumbs;
diff --git a/src/applications/health-care-supply-reordering/containers/App.jsx b/src/applications/health-care-supply-reordering/containers/App.jsx
@@ -63,7 +63,7 @@ class App extends Component {
     return (
       <>
         {!featureToggles.loading && (
-          <va-breadcrumbs uswds="false" class="va-nav-breadcrumbs">
+          <va-breadcrumbs class="va-nav-breadcrumbs">
             <a href="/">Home</a>
             {/* this will get updated when this route is added */}
             <a href="/health-care">Health care</a>
@@ -77,11 +77,13 @@ class App extends Component {
             Loading your information...
           </va-loading-indicator>
         )}
-        {isError && !pending && isLoggedIn && (
-          <div className="row vads-u-margin-bottom--3">
-            <ErrorMessage />
-          </div>
-        )}
+        {isError &&
+          !pending &&
+          isLoggedIn && (
+            <div className="row vads-u-margin-bottom--3">
+              <ErrorMessage />
+            </div>
+          )}
         {showMainContent && (
           <RoutedSavableApp formConfig={formConfig} currentLocation={location}>
             {children}
@@ -103,4 +105,7 @@ const mapDispatchToProps = dispatch => ({
   ...bindActionCreators({ fetchFormStatus }, dispatch),
 });
 
-export default connect(mapStateToProps, mapDispatchToProps)(App);
+export default connect(
+  mapStateToProps,
+  mapDispatchToProps,
+)(App);
diff --git a/src/applications/medical-copays/components/AlertView.jsx b/src/applications/medical-copays/components/AlertView.jsx
@@ -37,7 +37,7 @@ const AlertView = ({ pathname, alertType, error, cdpToggle, hasDebts }) => {
 
   return (
     <>
-      <VaBreadcrumbs uswds="false" label="Breadcrumb">
+      <VaBreadcrumbs label="Breadcrumb">
         <a href="/">Home</a>
         <a href="/health-care">Health care</a>
         <a href="/health-care/pay-copay-bill">Pay your VA copay bill</a>

diff --git a/src/applications/medical-copays/containers/DetailPage.jsx b/src/applications/medical-copays/containers/DetailPage.jsx
@@ -33,19 +33,19 @@ const DetailPage = ({ match }) => {
     mcpHTMLStatementToggle(state),
   );
 
-  useEffect(() => {
-    if (!isCurrentBalance) {
-      setAlert('past-due-balance');
-    }
-    scrollToTop();
-  }, [isCurrentBalance]);
+  useEffect(
+    () => {
+      if (!isCurrentBalance) {
+        setAlert('past-due-balance');
+      }
+      scrollToTop();
+    },
+    [isCurrentBalance],
+  );
 
   return (
     <>
-      <va-breadcrumbs
-        uswds="false"
-        className="vads-u-font-family--sans no-wrap"
-      >
+      <va-breadcrumbs className="vads-u-font-family--sans no-wrap">
         <a href="/">Home</a>
         <a href="/health-care">Health care</a>
         <a href="/health-care/pay-copay-bill">Pay your VA copay bill</a>

diff --git a/src/applications/medical-copays/containers/OverviewPage.jsx b/src/applications/medical-copays/containers/OverviewPage.jsx
@@ -59,7 +59,7 @@ const OverviewPage = () => {
   return (
     <>
       <div className="vads-u-font-family--sans no-wrap">
-        <VaBreadcrumbs uswds="false" label="Breadcrumb">
+        <VaBreadcrumbs label="Breadcrumb">
           <a href="/">Home</a>
           <a href="/health-care">Health care</a>
           <a href="/health-care/pay-copay-bill">Pay your VA copay bill</a>