Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile max-width of .row across repos #2521

Closed
3 tasks
webinista opened this issue Jun 27, 2016 · 1 comment
Closed
3 tasks

Reconcile max-width of .row across repos #2521

webinista opened this issue Jun 27, 2016 · 1 comment

Comments

@webinista
Copy link
Contributor

webinista commented Jun 27, 2016

Problem

Inconsistent max-width values across repos create problems for keeping everything in sync. A mix of multiple definitions and high specificity selectors means that .row doesn't behave the same way everywhere.

Selectors to refactor

From _va.scss

body .row.full {
  width: 100%;
  max-width: 100%;
}
.va-notice--banner {
  .row {
    max-width: 70em;
  }
}

From _hca.scss

body .row {
  max-width: 62.5em;
}

Suggested fixes:

  • Replace body .row.full selector with .va-row--full selector.
  • Modify markup of include/header.html so that .va-notice--banner .row no longer exists.
  • Change body .row to .row
@webinista
Copy link
Contributor Author

Closing. It's irrelevant for now, since we're eventually removing Foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant