Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Development] Allow dynamic form titles #13998

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[Development] Allow dynamic form titles #13998

merged 1 commit into from
Aug 25, 2020

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Aug 24, 2020 •
edited
Loading

Description

Form 526 form title can change depending on the flow. It is "File for disability compensation" for both original- and all-claims; but needs to be set as "File for Benefits Delivery at Discharge" for BDD flow.

Related issues

Testing done

Added FormApp unit test

Screenshots

N/A

Acceptance criteria

  • Form title can be dynamically updated

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@Mottie Mottie requested a review from a team August 24, 2020 22:12
@Mottie Mottie self-assigned this Aug 24, 2020
@Mottie Mottie requested a review from a team August 24, 2020 22:16
@Mottie Mottie mentioned this pull request Aug 24, 2020
Merged
6 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to master/12767-dynamic-title August 24, 2020 22:47 Inactive
@Mottie Mottie merged commit b0ab1c6 into master Aug 25, 2020
@Mottie Mottie deleted the 12767-dynamic-title branch August 25, 2020 21:14
@Mottie Mottie mentioned this pull request Aug 28, 2020
Merged
6 tasks
@Mottie Mottie mentioned this pull request Sep 18, 2020
Open
7 tasks
This was referenced Dec 1, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billfienberg billfienberg billfienberg approved these changes

@ndsprinkle ndsprinkle ndsprinkle approved these changes

Assignees

@Mottie Mottie

Labels
526 front end unicorns VSA vsa-claims-appeals Claims & appeals team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mottie @billfienberg @ndsprinkle @va-vfs-bot