DT 32404 & 31873 implementing PDF help modal #19368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsonic
reviewed
Nov 10, 2021
| }); | ||
| useEffect(() => { | ||
| const justRefreshed = prevProps?.fetching && !fetching; | ||
| if (justRefreshed) { | ||
| focusElement('[data-forms-focus]'); | ||
| } | ||
| }); | ||
| useEffect(() => { | ||
| const doesCookieExist = getCookie(); |
There was a problem hiding this comment.
is the return result from getCookie cookie? If so might be better calling doesCookieExist cookie instead so devs know they can inspect it for cookie details. Alternatively you could do something like !!getCookie() to get the boolean representation of cookie 🍪
There was a problem hiding this comment.
It returns a boolean. I perhaps should rename it? A good point there!
There was a problem hiding this comment.
ya getCookie sounds like it will return the cookie, I think if getCookie doesn't return back the string and a bool instead then perhaps rename it to doesCookieExist()?
kelsonic
approved these changes
Nov 10, 2021
| setModalState({ | ||
| ...modalState, | ||
| isOpen: !modalState.isOpen, | ||
| cookieExistence: true, |
There was a problem hiding this comment.
Any reason we wouldn't also call this doesCookieExist?
va-vfs-bot
temporarily deployed
to
master/DT-32404-31873-modalwork/master
va-vfs-bot
temporarily deployed
to
master/DT-32404-31873-modalwork/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing PDF Help modal for Form Detail page.
Original issue(s)
department-of-veterans-affairs/va.gov-team#32404
department-of-veterans-affairs/va.gov-team#31873
Testing done
Ran it locally with Vets website + content build repos
Screenshots
Acceptance criteria
Definition of done