-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT 32404 & 31873 implementing PDF help modal #19368
Conversation
}); | ||
useEffect(() => { | ||
const justRefreshed = prevProps?.fetching && !fetching; | ||
if (justRefreshed) { | ||
focusElement('[data-forms-focus]'); | ||
} | ||
}); | ||
useEffect(() => { | ||
const doesCookieExist = getCookie(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the return result from getCookie
cookie
? If so might be better calling doesCookieExist
cookie
instead so devs know they can inspect it for cookie details. Alternatively you could do something like !!getCookie()
to get the boolean representation of cookie
🍪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya getCookie
sounds like it will return the cookie, I think if getCookie
doesn't return back the string and a bool instead then perhaps rename it to doesCookieExist()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
setModalState({ | ||
...modalState, | ||
isOpen: !modalState.isOpen, | ||
cookieExistence: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we wouldn't also call this doesCookieExist
?
Description
Implementing PDF Help modal for Form Detail page.
Original issue(s)
department-of-veterans-affairs/va.gov-team#32404
department-of-veterans-affairs/va.gov-team#31873
Testing done
Ran it locally with Vets website + content build repos
Screenshots
Acceptance criteria
Definition of done