Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rated Disabilities] - Update va-link to v3 component #28762

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pmclaren19
Copy link
Contributor

@pmclaren19 pmclaren19 commented Mar 25, 2024

Summary

Updated the va-link in CombinedRating.jsx to use the v3 component. Found that a va-link using v1 was added after our audit of disability ratings and our initial pr to update all components to v3 didnt update this.

Related issue(s)

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
CombinedRating.jsx Screenshot 2024-03-25 at 12 10 20 PM Screenshot 2024-03-25 at 12 35 46 PM

What areas of the site does it impact?

Rated Disabilities

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

@pmclaren19 pmclaren19 self-assigned this Mar 25, 2024
@pmclaren19 pmclaren19 changed the title [Disability Rating] - Update va-link to v3 component [Rated Disabilities] - Update va-link to v3 component Mar 25, 2024
@pmclaren19 pmclaren19 marked this pull request as ready for review March 25, 2024 18:46
@pmclaren19 pmclaren19 requested review from a team as code owners March 25, 2024 18:46
@pmclaren19 pmclaren19 merged commit 3ec6600 into main Mar 25, 2024
84 checks passed
@pmclaren19 pmclaren19 deleted the 76124-update-combined-rating-va-link-to-use-uswds branch March 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants