Refactor pension form files #29250
Merged
Refactor pension form files #29250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
scottsdevelopment
changed the title
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
added 2 commits
April 22, 2024 11:56
# Conflicts: # src/applications/pensions/config/form.js
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
added 3 commits
April 25, 2024 14:38
…ugin." This reverts commit 7de1031
scottsdevelopment
force-pushed
the
feature/pension-form-js-optimization-2
branch
2 times, most recently
from
d3ab8d2
to
bc2285d
Compare
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
va-vfs-bot
temporarily deployed
to
master/feature/pension-form-js-optimization-2/main
wayne-weibel
approved these changes
Apr 29, 2024
va-vfs-bot
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
| mode: 'cors', | ||
| }).catch(res => { | ||
| if (res instanceof Error) { | ||
| Sentry.captureException(res); |
| }).catch(res => { | ||
| if (res instanceof Error) { | ||
| Sentry.captureException(res); | ||
| Sentry.captureMessage('vets_pension_poll_client_error'); |
ToddWebDev
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
node script/build-form-docs.js > src/applications/pensions/21p527ez/form.mdRelated issue(s)
Considerations