Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask VA 831-Design Changes for Your Contact information - "Your contact information" #29431

Merged

Conversation

hemeshvpatel
Copy link
Contributor

@hemeshvpatel hemeshvpatel commented Apr 25, 2024

Summary

  • Changes to the layout (as described in Figma) have been incorporated
  • Conditionals for the "How should we contact you" will be in a follow up ticket based on this guide
  • The Ask VA team owns this page
  • This is part of our POC

Related issue(s)

  • Link to the ticket here

Testing done

  • Updated existing tests

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

image

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@hemeshvpatel hemeshvpatel self-assigned this Apr 25, 2024
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. UI edits here, logic/flow to be played in a separate ticket.

@ediiotero ediiotero merged commit 40a42fe into main Apr 29, 2024
75 of 76 checks passed
@ediiotero ediiotero deleted the Ask-VA-831/Design-Changes-for-Your-Contact-Information branch April 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants