Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] - Updated Documents Filed so that the documents are sorted correctly #29456

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

pmclaren19
Copy link
Contributor

@pmclaren19 pmclaren19 commented Apr 26, 2024

Summary

  • Updated DocumentsFiled.jsx so that the logic accounts for trackeditems having multiple documents and the document upload date being different then that of the tracked items
  • When there is an uploadDate in the trackedItems documents, we will sort on the date of the first document and use that as the date that is shown instead of the trackedItem date
  • Added a test to DocumentsFiled.unit.spec.jsx around the above scenario

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Documents Filed List Screenshot 2024-04-26 at 3 31 38 PM Screenshot 2024-04-26 at 3 41 01 PM

What areas of the site does it impact?

Claim Status Tool

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

@pmclaren19 pmclaren19 self-assigned this Apr 26, 2024
@pmclaren19 pmclaren19 changed the title [CST] - Updated Documents Filed so that the tracked items [CST] - Updated Documents Filed so that the documents are sorted correctly Apr 26, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/81756-Resolve-documents-filed-bug/main April 26, 2024 21:56 Inactive
<i className="fa fa-check-circle docs-filed-icon" />
<va-icon
size={4}
icon="see Storybook for icon names: https://design.va.gov/storybook/?path=/docs/uswds-va-icon--default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the icon value here needs to be updated. Also use class instead of className for web components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never intended to update the icon so not quite sure how this got added, rolling it back to what it was.

samcoforma
samcoforma previously approved these changes Apr 29, 2024
@pmclaren19 pmclaren19 merged commit cc5c6a3 into main Apr 29, 2024
80 of 81 checks passed
@pmclaren19 pmclaren19 deleted the 81756-Resolve-documents-filed-bug branch April 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants