#VYE-360 #comment new format for enrollment logic

[jsimonVA]

Summary

• (Summarize the changes that have been made to the platform)
• • Changes made to the way enrollment logic is read based on the new format that enrollment logic will be sent to the frontend via API.
• _(If bug, how to reproduce)_NA
• (What is the solution, why is this the solution)
• The solution was to rewrite the functions related to reading the enrollment logic, so that it displays on screen in the same fashion as it did before the enrollment format changed.
• (Which team do you work for, does your team own the maintenance of this component?)
• • I work for GovCIO we are the code owners of this change
• (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
• • No flipper. Code is in staging only.

Related issue(s)

Jira Ticket -> https://jira.devops.va.gov/browse/VYE-360

As:

• VYE Dev

I need:

• to rewrite the logic for how the code reads in enrollment data

So that:

• the code can read the new format enrollment will be passed to the frontend

Considerations:

• No considerations

Acceptance Criteria:

• This logic is behind the scene changes and no change will be made visually
• enrollment logic is read and shown on the screen as it previously did

Testing Considerations:

• Unit tests will be updated/ local testing and Staging testing will be conducted
• There are changes in logic in the code, but it should look the same

Other Considerations:

• No other considerations

Testing done

• _Describe what the old behavior was prior to the change_NA
• Describe the steps required to verify your changes are working as expected
• • No visual change
• Describe the tests completed and the results
• • Update Unit tests to accommodate the modified functions related to reading enrollment logic
• _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
• Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

	Before	After
Mobile
Desktop

What areas of the site does it impact?

• This impacts the Verify Your Enrollment application only.

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

• Enrollment periods are visible (No change)

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

• The vets-website header does not contain any web-components
• I used the proxy-rewrite steps to test the injected header scenario
• I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?