Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASK VA 966/ Education search bug #29541

Merged
merged 1 commit into from
May 3, 2024
Merged

ASK VA 966/ Education search bug #29541

merged 1 commit into from
May 3, 2024

Conversation

ediiotero
Copy link
Contributor

Summary

  • Fixing a bug in the Education search page also updated required questions.
  • There was a missing / in the string calling the endpoint.

Related issue(s)

Testing done

  • Manual tests done to confirm search is working.

Screenshots

UI has not changed.

What areas of the site does it impact?

This only impacts the Ask VA form.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@ediiotero ediiotero requested a review from a team as a code owner May 2, 2024 14:17
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will the direct call to VA.gov APIs be replaced with a pass-thru from our API?

@ediiotero
Copy link
Contributor Author

LGTM. Will the direct call to VA.gov APIs be replaced with a pass-thru from our API?

Yup. When Khoa is done with his work for the search endpoint this will be updated as well.

@ediiotero ediiotero merged commit 0912f01 into main May 3, 2024
68 of 69 checks passed
@ediiotero ediiotero deleted the ask-va-966/search-bug branch May 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants