Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies defined in package scripts not detected. #200

Closed
robhaswell opened this issue Jan 25, 2017 · 4 comments
Closed

devDependencies defined in package scripts not detected. #200

robhaswell opened this issue Jan 25, 2017 · 4 comments

Comments

@robhaswell
Copy link

Thank you for this wonderful tool. However, depcheck seems to think that my project is not using standard, yet it is used in my package scripts:

{
  "scripts": {
    "start": "node app",
    "test": "npm run check-style && (istanbul cover --include-all-sources tape -- '!(node_modules)/**/*.test.js' | tap-dot) && npm run check-coverage && npm run check-security",
    "quick-test": "tape '!(node_modules)/**/*.test.js' | ./node_modules/.bin/tap-spec",
    "check-test": "istanbul cover --include-all-sources tape -- '!(node_modules)/**/*.test.js' | tap-dot",
    "check-security": "nsp check",
    "check-coverage": "istanbul check-coverage",
    "check-style": "standard",
    "lint": "standard"
  }
}

depcheck --json | json_pp:

{
   "using" : {
      "jsonwebtoken" : [
         "/Users/cloudfind/Projects/jetski/lib/authenticate.js",
         "/Users/cloudfind/Projects/jetski/lib/test/authenticate.test.js"
      ],
      "nsp" : [
         "/Users/cloudfind/Projects/jetski/package.json"
      ],
      "supertest" : [
         "/Users/cloudfind/Projects/jetski/lib/test/app.test.js",
         "/Users/cloudfind/Projects/jetski/lib/test/authenticate.test.js"
      ],
      "cookies" : [
         "/Users/cloudfind/Projects/jetski/lib/authenticate.js"
      ],
      "bole" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/lib/logger.js"
      ],
      "helmet" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/web/server.js"
      ],
      "tape" : [
         "/Users/cloudfind/Projects/jetski/lib/test/app.test.js",
         "/Users/cloudfind/Projects/jetski/lib/test/append-user-info.test.js",
         "/Users/cloudfind/Projects/jetski/lib/test/authenticate.test.js",
         "/Users/cloudfind/Projects/jetski/lib/test/sqs-prototype.test.js"
      ],
      "response-time" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/web/server.js"
      ],
      "proxyquire" : [
         "/Users/cloudfind/Projects/jetski/lib/test/app.test.js"
      ],
      "morgan" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/web/server.js"
      ],
      "tap-dot" : [
         "/Users/cloudfind/Projects/jetski/package.json"
      ],
      "express" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/lib/test/authenticate.test.js",
         "/Users/cloudfind/Projects/jetski/web/server.js"
      ],
      "mississippi" : [
         "/Users/cloudfind/Projects/jetski/lib/sqs-prototype.js"
      ],
      "istanbul" : [
         "/Users/cloudfind/Projects/jetski/package.json"
      ],
      "aws-sdk" : [
         "/Users/cloudfind/Projects/jetski/lib/sqs.js"
      ],
      "hat" : [
         "/Users/cloudfind/Projects/jetski/app.js",
         "/Users/cloudfind/Projects/jetski/web/server.js"
      ]
   },
   "invalidFiles" : {},
   "dependencies" : [
      "body-parser",
      "cluster",
      "ejs",
      "fs",
      "metrics",
      "prettyjson"
   ],
   "missing" : {},
   "devDependencies" : [
      "garnish",
      "nodemon",
      "standard",
      "watchify"
   ],
   "invalidDirs" : {}
}

Many thanks,

@junedev
Copy link

junedev commented Jun 15, 2017

I am experiencing the same a lot of times. Here is one example where nodemon is considered unused.
package.json:

"scripts": {
    "build": "tsc -p src/",
    "build:watch": "tsc -p src/ -w",
    "watch": "concurrently \"npm run build:watch\" \"nodemon app.js\"",
    "start": "node app.js",
    "lint": "tslint ./src/**/*.ts -t verbose"
}

depcheck --json:

{
    "dependencies": [
        "@angular/forms",
        "@angular/http",
        "@angular/router",
        "angular-in-memory-web-api",
        "systemjs",
        "core-js",
        "node-sass",
        "request",
        "socket.io",
        "twit"
    ],
    "devDependencies": [
        "@types/node",
        "nodemon"
    ],
    "missing": {},
    "using": {
        "morgan": [
            "/home/xyz/app.js"
        ],
        "express": [
            "/home/xyz/app.js"
        ],
        "node-sass-middleware": [
            "/home/xyz/app.js"
        ],
        "concurrently": [
            "/home/xyz/package.json"
        ],
        "tslint": [
            "/home/xyz/package.json"
        ],
        "typescript": [
            "/home/xyz/package.json"
        ],
        "@angular/core": [
            "/home/xyz/src/app/app.module.ts",
            "/home/xyz/src/app/app.component.ts",
            "/home/xyz/src/main.ts",
            "/home/xyz/public/app/app.component.js",
            "/home/xyz/public/app/app.module.js",
            "/home/xyz/public/main.js"
        ],
        "@angular/platform-browser": [
            "/home/xyz/src/app/app.module.ts",
            "/home/xyz/src/main.ts",
            "/home/xyz/public/app/app.module.js",
            "/home/xyz/public/main.js"
        ],
        "rxjs": [
            "/home/xyz/src/app/app.module.ts",
            "/home/xyz/src/app/app.component.ts",
            "/home/xyz/public/app/app.component.js",
            "/home/xyz/public/app/app.module.js"
        ],
        "zone.js": [
            "/home/xyz/src/app/app.module.ts",
            "/home/xyz/src/app/app.component.ts",
            "/home/xyz/public/app/app.component.js",
            "/home/xyz/public/app/app.module.js"
        ],
        "@angular/common": [
            "/home/xyz/src/app/app.module.ts",
            "/home/xyz/src/main.ts",
            "/home/xyz/public/app/app.module.js",
            "/home/xyz/public/main.js"
        ],
        "@angular/platform-browser-dynamic": [
            "/home/xyz/src/main.ts",
            "/home/xyz/public/main.js"
        ],
        "@angular/compiler": [
            "/home/xyz/src/main.ts",
            "/home/xyz/public/main.js"
        ]
    },
    "invalidFiles": {},
    "invalidDirs": {}
}

@stale
Copy link

stale bot commented Nov 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 2, 2019
@VincentLanglet
Copy link
Contributor

@rumpl This issue can be closed thanks to this PR #358

@stale stale bot removed the wontfix label Nov 3, 2019
@rumpl
Copy link
Member

rumpl commented Nov 3, 2019

Thank you for your work ^^

@rumpl rumpl closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants