Fixing Issue #200: packages with bin that haven't been detected #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this PR @2roy999 ! Code looks good, will merge it as soon as the build is green. Do you need this quickly or can I wait a little to publish a new version? |
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 98.83% 98.83% +<.01%
==========================================
Files 34 34
Lines 684 687 +3
==========================================
+ Hits 676 679 +3
Misses 8 8
Continue to review full report at Codecov.
|
|
@rumpl It can wait for the next version. Thank you :) |
rumpl
approved these changes
Jun 17, 2019
|
Thanks @2roy999 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages have a string of a single binary file instead of an object with the names of the binaries. This caused depcheck to declare those packages as missed. (Issue #200)