-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: include tslint in deps when a tslintrc exists #325
Conversation
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
======================================
Coverage 98.4% 98.4%
======================================
Files 32 32
Lines 563 563
======================================
Hits 554 554
Misses 9 9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 98.41% 98.42% +<.01%
==========================================
Files 32 32
Lines 569 570 +1
==========================================
+ Hits 560 561 +1
Misses 9 9
Continue to review full report at Codecov.
|
alright so i've made a change to the config file regex matching, too. it turns out our patterns were kinda wrong.. ESLint supports: should this be considered a breaking change? as we will no longer support those unsupported filenames. |
Huh, weird that we thought that there was a |
Could you please rebase so that we can merge safely, thanks! |
I suspect it may have been supported a very long time ago, or could just be an easy typo as some aged projects do have such a file. Tslint deprecation is great news. Eslint already supported typescript for a long time now. Will rebase soon too |
@rumpl rebased |
Merged 🎉 |
This should fix part of a few issues like #319.
I introduced
tslint
as a dependency every time atslintrc
file exists. Let me know if you think this is reasonable (and also if its fine that we still expect it when the tslint config is invalid).