Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load next config with import instead of require #786

Merged
merged 1 commit into from Mar 28, 2023
Merged

Conversation

cprussin
Copy link
Contributor

Fixes #762

@codecov-commenter
Copy link

Codecov Report

Merging #786 (b7a0428) into main (f9eb0ed) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          50       50           
  Lines        1052     1052           
=======================================
  Hits         1034     1034           
  Misses         18       18           
Impacted Files Coverage Δ
src/special/webpack.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5132d5e...b7a0428. Read the comment docs.

@cprussin
Copy link
Contributor Author

cc @rumpl

Looks like the CI issue above is unrelated to the PR, and has failed in all open PRs as well.

Any objection to merging this?

@rumpl rumpl merged commit ce980c1 into depcheck:main Mar 28, 2023
5 of 6 checks passed
@cprussin
Copy link
Contributor Author

@rumpl sorry to bug you but any chance you'd be willing to cut a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to analyze next.config.js in a ESM package
3 participants