Add cross-platform path support for proxy certificates #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
internal/infra/proxy.goincludes changes to simplify the codebase and improve the handling of file paths. The most important changes include removing thestringspackage from the import block and replacing the usage ofstrings.HasPrefixwithpath.IsAbsto check if a file path is absolute.Codebase simplification:
internal/infra/proxy.go: Removed thestringspackage from the import block as it is no longer needed.Improvements in file path handling:
internal/infra/proxy.go: In theNewProxyfunction, replaced the usage ofstrings.HasPrefixwithpath.IsAbsto check ifparams.ProxyCertPathis an absolute path. This approach is more reliable and idiomatic for checking absolute paths in Go.