Skip to content

Commit

Permalink
Add yamllint to linters
Browse files Browse the repository at this point in the history
We've got a lot of YAML in this repo... as this repo gets more popular,
we'll benefit from having some consistency / linter in place.

I loosened up the default rule set a bit to allow flexibility for a
variety of styles, as long as things were internally consistent to the
file.
  • Loading branch information
jeffwidman committed Aug 22, 2023
1 parent 6e78ed8 commit 37c6c4d
Show file tree
Hide file tree
Showing 42 changed files with 534 additions and 506 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ updates:
groups:
aws-sdk:
patterns:
- "aws-sdk-*"
- "aws-sdk-*"

# Watch the per-ecosystem native helpers
- package-ecosystem: "composer"
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Specs
on:
on: # yamllint disable-line rule:truthy
push:
branches:
- "main"
Expand Down Expand Up @@ -242,3 +242,5 @@ jobs:
with:
bundler-cache: true
- run: ./bin/lint
# yamllint is installed in GitHub Actions base runner image: https://github.com/adrienverge/yamllint/pull/588
- run: yamllint .
64 changes: 32 additions & 32 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#
name: "CodeQL"

on:
on: # yamllint disable-line rule:truthy
push:
branches: [ main ]
pull_request:
Expand Down Expand Up @@ -45,41 +45,41 @@ jobs:
# Learn more about CodeQL language support at https://git.io/codeql-language-support

steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Checkout repository
uses: actions/checkout@v3

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL (ruby)
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
config: |
paths-ignore:
- 'bundler/spec/fixtures/projects/bundler1/invalid_ruby/Gemfile'
- 'bundler/spec/fixtures/projects/bundler2/invalid_ruby/Gemfile'
if: matrix.language == 'ruby'
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL (ruby)
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
config: |
paths-ignore:
- 'bundler/spec/fixtures/projects/bundler1/invalid_ruby/Gemfile'
- 'bundler/spec/fixtures/projects/bundler2/invalid_ruby/Gemfile'
if: matrix.language == 'ruby'

- name: Initialize CodeQL (others)
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
if: matrix.language != 'ruby'
- name: Initialize CodeQL (others)
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
if: matrix.language != 'ruby'

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2

# 鈩癸笍 Command-line programs to run using the OS shell.
# 馃摎 https://git.io/JvXDl
# 鈩癸笍 Command-line programs to run using the OS shell.
# 馃摎 https://git.io/JvXDl

# 鉁忥笍 If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language
# 鉁忥笍 If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release
# - run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Dependency Review
on: [pull_request]
on: [pull_request] # yamllint disable-line rule:truthy

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gems-bump-version.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Gems - Bump Version
on:
on: # yamllint disable-line rule:truthy
schedule:
- cron: '25 1 * * THU'
workflow_dispatch:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gems-release-to-rubygems.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Gems - Release to RubyGems
on:
on: # yamllint disable-line rule:truthy
release:
# It's fine to trigger on every release because if we tag a release w/o
# bumping the Gem version, RubyGems will reject it with an error that the
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/images-branch.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Branch images
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
on:
on: # yamllint disable-line rule:truthy
pull_request:
branches:
- main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/images-latest.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Latest images
env:
UPDATER_IMAGE: "ghcr.io/dependabot/dependabot-updater-"
on:
on: # yamllint disable-line rule:truthy
push:
branches:
- main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/images-updater-core.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Updater-Core image
env:
UPDATER_CORE_IMAGE: "ghcr.io/dependabot/dependabot-updater-core"
on:
on: # yamllint disable-line rule:truthy
push:
branches:
- main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Pull Request Labeler

on:
on: # yamllint disable-line rule:truthy
- pull_request_target

jobs:
Expand Down

0 comments on commit 37c6c4d

Please sign in to comment.