Merge branch 'main' into GarryHurleyJr/6039-add-support-in-dependabot…

…-core-for-lfs-as-an-option-for-repositories

.github/workflows/ci.yml

@@ -42,11 +42,11 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
         with:
           submodules: recursive
 
-      - uses: dorny/paths-filter@v3
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: changes
         with:
           filters: .github/ci-filters.yml
@@ -74,7 +74,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
         with:
           submodules: recursive
       # using bundler as the test updater
@@ -91,8 +91,8 @@ jobs:
     env:
       BUNDLE_GEMFILE: updater/Gemfile
     steps:
-      - uses: actions/checkout@v4
-      - uses: ruby/setup-ruby@v1
+      - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+      - uses: ruby/setup-ruby@cacc9f1c0b3f4eb8a16a6bb0ed10897b43b9de49 # v1.176.0
         with:
           bundler-cache: true
       - run: ./bin/lint
@@ -105,13 +105,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
         with:
           submodules: recursive
       - name: Build ecosystem image
         run: script/build silent
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
         with:
           go-version: 1.21
       - name: Download Dependabot CLI

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-05-13 10:05:42 UTC using RuboCop version 1.63.2.
+# on 2024-05-17 06:52:32 UTC using RuboCop version 1.63.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -38,14 +38,6 @@ RSpec/BeEql:
     - 'updater/spec/dependabot/dependency_snapshot_spec.rb'
     - 'updater/spec/dependabot/job_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-RSpec/BeNil:
-  Exclude:
-    - 'gradle/spec/dependabot/gradle/file_parser_spec.rb'
-
 # Offense count: 7
 RSpec/BeforeAfterAll:
   Exclude:
@@ -54,17 +46,30 @@ RSpec/BeforeAfterAll:
     - 'pub/spec/dependabot/pub/infer_sdk_versions_spec.rb'
     - 'pub/spec/dependabot/pub/update_checker_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ContainExactly:
-  Exclude:
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker_spec.rb'
-
-# Offense count: 2237
+# Offense count: 2229
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
-  Enabled: false
+  Exclude:
+    - 'cargo/**/*'
+    - 'common/**/*'
+    - 'composer/**/*'
+    - 'devcontainers/**/*'
+    - 'docker/**/*'
+    - 'elm/**/*'
+    - 'git_submodules/**/*'
+    - 'github_actions/**/*'
+    - 'go_modules/**/*'
+    - 'gradle/**/*'
+    - 'hex/**/*'
+    - 'maven/**/*'
+    - 'npm_and_yarn/**/*'
+    - 'nuget/**/*'
+    - 'pub/**/*'
+    - 'python/**/*'
+    - 'sorbet/**/*'
+    - 'terraform/**/*'
+    - 'updater/**/*'
 
 # Offense count: 31
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -86,15 +91,6 @@ RSpec/DescribedClass:
     - 'updater/spec/dependabot/api_client_spec.rb'
     - 'updater/spec/dependabot/job_spec.rb'
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'cargo/spec/dependabot/cargo/file_fetcher_spec.rb'
-    - 'composer/spec/dependabot/composer/file_updater/lockfile_updater_spec.rb'
-    - 'nuget/spec/dependabot/nuget/file_fetcher_spec.rb'
-    - 'nuget/spec/dependabot/nuget/update_checker/version_finder_spec.rb'
-
 # Offense count: 173
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowConsecutiveOneLiners.
@@ -116,7 +112,7 @@ RSpec/EmptyLineAfterExampleGroup:
     - 'terraform/spec/dependabot/terraform/requirement_spec.rb'
     - 'terraform/spec/dependabot/terraform/requirements_updater_spec.rb'
 
-# Offense count: 2166
+# Offense count: 2162
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/EmptyLineAfterFinalLet:
   Enabled: false
@@ -127,12 +123,12 @@ RSpec/EmptyLineAfterFinalLet:
 RSpec/EmptyLineAfterHook:
   Enabled: false
 
-# Offense count: 283
+# Offense count: 288
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/EmptyLineAfterSubject:
   Enabled: false
 
-# Offense count: 1285
+# Offense count: 1286
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 98
@@ -187,36 +183,12 @@ RSpec/FilePath:
     - 'nuget/spec/dependabot/nuget/update_checker/repository_finder_spec.rb'
     - 'nuget/spec/dependabot/nuget/update_checker/tfm_finder_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/Focus:
-  Exclude:
-    - 'common/spec/dependabot/file_fetchers/base_spec.rb'
-    - 'common/spec/dependabot/pull_request_creator/message_builder_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  Exclude:
-    - 'common/spec/dependabot/clients/azure_spec.rb'
-    - 'common/spec/dependabot/clients/bitbucket_spec.rb'
-
 # Offense count: 56
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/HooksBeforeExamples:
   Enabled: false
 
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: is_expected, should
-RSpec/ImplicitExpect:
-  Exclude:
-    - 'common/spec/dependabot/pull_request_creator/message_builder_spec.rb'
-
-# Offense count: 212
+# Offense count: 213
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
@@ -271,7 +243,7 @@ RSpec/IteratedExpectation:
     - 'python/spec/dependabot/python/file_updater/requirement_file_updater_spec.rb'
     - 'python/spec/dependabot/python/file_updater_spec.rb'
 
-# Offense count: 125
+# Offense count: 126
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/LeadingSubject:
   Enabled: false
@@ -299,14 +271,12 @@ RSpec/MessageChain:
 RSpec/MessageSpies:
   Enabled: false
 
-# Offense count: 10
+# Offense count: 8
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: hash, symbol
 RSpec/MetadataStyle:
   Exclude:
-    - 'common/spec/dependabot/file_fetchers/base_spec.rb'
-    - 'common/spec/dependabot/pull_request_creator/message_builder_spec.rb'
     - 'hex/spec/dependabot/hex/update_checker/version_resolver_spec.rb'
     - 'terraform/spec/dependabot/terraform/file_parser_spec.rb'
     - 'updater/spec/dependabot/file_fetcher_command_spec.rb'
@@ -316,11 +286,11 @@ RSpec/MultipleDescribes:
   Exclude:
     - 'common/spec/dependabot/errors_spec.rb'
 
-# Offense count: 1377
+# Offense count: 1380
 RSpec/MultipleExpectations:
   Max: 17
 
-# Offense count: 5345
+# Offense count: 5339
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 30
@@ -357,12 +327,6 @@ RSpec/OverwritingSetup:
     - 'terraform/spec/dependabot/terraform/file_parser_spec.rb'
     - 'updater/spec/dependabot/dependency_snapshot_spec.rb'
 
-# Offense count: 2
-RSpec/PendingWithoutReason:
-  Exclude:
-    - 'bundler/spec/dependabot/bundler/update_checker_spec.rb'
-    - 'go_modules/spec/dependabot/go_modules/path_converter_spec.rb'
-
 # Offense count: 47
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
@@ -394,11 +358,6 @@ RSpec/ReceiveMessages:
     - 'updater/spec/dependabot/file_fetcher_command_spec.rb'
     - 'updater/spec/dependabot/update_files_command_spec.rb'
 
-# Offense count: 2
-RSpec/RepeatedDescription:
-  Exclude:
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/file_fetcher_spec.rb'
-
 # Offense count: 4
 RSpec/RepeatedExample:
   Exclude:
@@ -483,17 +442,11 @@ RSpec/StubbedMock:
     - 'updater/spec/dependabot/update_files_command_spec.rb'
     - 'updater/spec/dependabot/updater_spec.rb'
 
-# Offense count: 5
-RSpec/SubjectDeclaration:
-  Exclude:
-    - 'npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/dependency_files_builder_spec.rb'
-
-# Offense count: 34
+# Offense count: 28
 RSpec/SubjectStub:
   Exclude:
     - 'common/spec/dependabot/metadata_finders/base/commits_finder_spec.rb'
     - 'common/spec/dependabot/metadata_finders/base_spec.rb'
-    - 'common/spec/dependabot/pull_request_creator/message_builder_spec.rb'
     - 'common/spec/dependabot/pull_request_updater/azure_spec.rb'
     - 'updater/spec/dependabot/environment_spec.rb'
     - 'updater/spec/dependabot/sentry/exception_sanitizer_processor_spec.rb'