Skip to content

Commit

Permalink
Map updater ecosystem to bundler (#6570)
Browse files Browse the repository at this point in the history
Technically every ecosystem results in building a per-ecosystem updater
image. But currently running the `updater` unit tests requires the
`bundler` ecosystem image.

So this is a convenience to make it so we don't have to rememeber that
and can just run `bin/docker-dev-shell updater`.
  • Loading branch information
jeffwidman committed Apr 20, 2023
1 parent 5b75a33 commit 60033d6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
9 changes: 8 additions & 1 deletion bin/docker-dev-shell
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ fi
if [[ -z "$1" ]]; then
HELP=true
fi
ECOSYSTEM="$1"

# Technically every ecosystem results in building a per-ecosystem updater image.
# But currently running the `updater` unit tests requires the `bundler` ecosystem image.
if [ "$1" == "updater" ]; then
ECOSYSTEM="bundler"
else
ECOSYSTEM="$1"
fi

while true; do
case "$2" in
Expand Down
5 changes: 2 additions & 3 deletions updater/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@ GitHub network, and so is not generally accessible.

## Setup

To work on the Updater, you will need to start a Docker dev shell. The bundler
shell will suffice
To work on the Updater, you will need to start a Docker dev shell:

```zsh
➜ bin/docker-dev-shell bundler
➜ bin/docker-dev-shell updater # the docker-dev-shell internally maps 'updater' to the 'bundler' ecosystem image
[dependabot-core-dev] ~/dependabot-core $ cd updater/
[dependabot-core-dev] ~/dependabot-core/updater $ bundle
```
Expand Down

0 comments on commit 60033d6

Please sign in to comment.