Enabling RSpec HooksBefore rubocop rule (#9974)

* Enabling RSpec HooksBefore rubocop rule

* Fixing lint issues due to misapplied rubocop rules

.rubocop_todo.yml

@@ -51,12 +51,6 @@ RSpec/FilePath:
     - 'nuget/spec/dependabot/nuget/update_checker/repository_finder_spec.rb'
     - 'nuget/spec/dependabot/nuget/update_checker/tfm_finder_spec.rb'
 
-# Offense count: 56
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/HooksBeforeExamples:
-  Enabled: false
-
-
 # Offense count: 70
 # Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:

bundler/spec/dependabot/bundler/file_fetcher_spec.rb

@@ -28,8 +28,6 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before do
     allow(file_fetcher_instance).to receive(:commit).and_return("sha")
     stub_request(:get, File.join(url, ".ruby-version?ref=sha"))
@@ -47,8 +45,11 @@
         body: fixture("github", "tool_versions_content.json"),
         headers: { "content-type" => "application/json" }
       )
+    allow(file_fetcher_instance).to receive(:commit).and_return("sha")
   end
 
+  it_behaves_like "a dependency file fetcher"
+
   context "with a directory" do
     let(:directory) { "/test" }
     let(:url) { "https://api.github.com/repos/gocardless/bump/contents/test" }

bundler/spec/dependabot/bundler/file_updater_spec.rb

@@ -50,10 +50,10 @@
     )
   end
 
-  it_behaves_like "a dependency file updater"
-
   before { FileUtils.mkdir_p(tmp_path) }
 
+  it_behaves_like "a dependency file updater"
+
   describe "#updated_dependency_files" do
     subject(:updated_files) { updater.updated_dependency_files }
 

bundler/spec/dependabot/bundler/metadata_finder_spec.rb

@@ -34,8 +34,6 @@
     )
   end
 
-  it_behaves_like "a dependency metadata finder"
-
   before do
     stub_request(:get, "https://example.com/status").to_return(
       status: 200,
@@ -50,6 +48,8 @@
     )
   end
 
+  it_behaves_like "a dependency metadata finder"
+
   describe "#source_url" do
     subject(:source_url) { finder.source_url }
 

cargo/spec/dependabot/cargo/file_fetcher_spec.rb

@@ -27,8 +27,6 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before do
     allow(file_fetcher_instance).to receive(:commit).and_return("sha")
     stub_request(:get, url + "Cargo.toml?ref=sha")
@@ -62,8 +60,11 @@
         body: fixture("github", "contents_cargo_config.json"),
         headers: json_header
       )
+    allow(file_fetcher_instance).to receive(:commit).and_return("sha")
   end
 
+  it_behaves_like "a dependency file fetcher"
+
   context "with a lockfile" do
     before do
       stub_request(:get, url + "?ref=sha")

cargo/spec/dependabot/cargo/file_updater_spec.rb

@@ -51,10 +51,10 @@
     )
   end
 
-  it_behaves_like "a dependency file updater"
-
   before { FileUtils.mkdir_p(tmp_path) }
 
+  it_behaves_like "a dependency file updater"
+
   describe "#updated_dependency_files" do
     subject(:updated_files) { updater.updated_dependency_files }
 

cargo/spec/dependabot/cargo/metadata_finder_spec.rb

@@ -35,8 +35,6 @@
     )
   end
 
-  it_behaves_like "a dependency metadata finder"
-
   before do
     stub_request(:get, "https://example.com/status").to_return(
       status: 200,
@@ -45,6 +43,8 @@
     )
   end
 
+  it_behaves_like "a dependency metadata finder"
+
   describe "#source_url" do
     subject(:source_url) { finder.source_url }
 

cargo/spec/dependabot/cargo/update_checker_spec.rb

@@ -64,12 +64,12 @@
   let(:crates_response) { fixture("crates_io_responses", crates_fixture_name) }
   let(:crates_url) { "https://crates.io/api/v1/crates/#{dependency_name}" }
 
-  it_behaves_like "an update checker"
-
   before do
     stub_request(:get, crates_url).to_return(status: 200, body: crates_response)
   end
 
+  it_behaves_like "an update checker"
+
   describe "#can_update?" do
     subject { checker.can_update?(requirements_to_unlock: :own) }
 

common/spec/dependabot/file_fetchers/base_spec.rb

@@ -307,8 +307,6 @@ def fetch_files
     context "with a GitHub source" do
       let(:url) { "https://api.github.com/repos/#{repo}/contents/" }
 
-      its(:length) { is_expected.to eq(1) }
-
       before do
         stub_request(:get, url + "requirements.txt?ref=sha")
           .with(headers: { "Authorization" => "token token" })
@@ -317,6 +315,8 @@ def fetch_files
                      headers: { "content-type" => "application/json" })
       end
 
+      its(:length) { is_expected.to eq(1) }
+
       describe "the file" do
         subject(:files_find) { files.find { |file| file.name == "requirements.txt" } }
 

composer/spec/dependabot/composer/file_fetcher_spec.rb

@@ -27,8 +27,6 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before do
     allow(file_fetcher_instance).to receive(:commit).and_return("sha")
 
@@ -55,6 +53,8 @@
       )
   end
 
+  it_behaves_like "a dependency file fetcher"
+
   it "fetches the composer.json and composer.lock" do
     expect(file_fetcher_instance.files.map(&:name))
       .to match_array(%w(composer.json composer.lock))

composer/spec/dependabot/composer/file_updater_spec.rb

@@ -46,10 +46,10 @@
     )
   end
 
-  it_behaves_like "a dependency file updater"
-
   before { FileUtils.mkdir_p(tmp_path) }
 
+  it_behaves_like "a dependency file updater"
+
   describe "#updated_dependency_files" do
     subject(:updated_files) { updater.updated_dependency_files }
 

composer/spec/dependabot/composer/metadata_finder_spec.rb

@@ -38,8 +38,6 @@
     )
   end
 
-  it_behaves_like "a dependency metadata finder"
-
   before do
     packagist_url = "https://repo.packagist.org/p2/#{dependency_name.downcase}.json"
     stub_request(:get, packagist_url).to_return(status: 200, body: packagist_response)
@@ -51,6 +49,8 @@
     )
   end
 
+  it_behaves_like "a dependency metadata finder"
+
   describe "#source_url" do
     subject(:source_url) { finder.source_url }
 

composer/spec/dependabot/composer/update_checker_spec.rb

@@ -47,13 +47,13 @@
     )
   end
 
-  it_behaves_like "an update checker"
-
   before do
     url = "https://repo.packagist.org/p2/#{dependency_name.downcase}.json"
     stub_request(:get, url).to_return(status: 200, body: packagist_response)
   end
 
+  it_behaves_like "an update checker"
+
   describe "#latest_version" do
     subject(:latest_version) { checker.latest_version }
 

docker/spec/dependabot/docker/file_fetcher_spec.rb

@@ -32,10 +32,10 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before { allow(file_fetcher_instance).to receive(:commit).and_return("sha") }
 
+  it_behaves_like "a dependency file fetcher"
+
   context "with no Dockerfile or Kubernetes YAML file" do
     before do
       stub_request(:get, url + "?ref=sha")

docker/spec/dependabot/docker/update_checker_spec.rb

@@ -49,8 +49,6 @@
     )
   end
 
-  it_behaves_like "an update checker"
-
   before do
     auth_url = "https://auth.docker.io/token?service=registry.docker.io"
     stub_request(:get, auth_url)
@@ -60,6 +58,8 @@
       .and_return(status: 200, body: registry_tags)
   end
 
+  it_behaves_like "an update checker"
+
   def stub_tag_with_no_digest(tag)
     stub_request(:head, repo_url + "manifests/#{tag}")
       .and_return(status: 200, headers: JSON.parse(headers_response).except("docker_content_digest"))

elm/spec/dependabot/elm/file_fetcher_spec.rb

@@ -27,8 +27,6 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before do
     allow(file_fetcher_instance).to receive(:commit).and_return("sha")
     stub_request(:get, url + "?ref=sha")
@@ -45,8 +43,11 @@
         body: fixture("github", "contents_elm_package.json"),
         headers: json_header
       )
+    allow(file_fetcher_instance).to receive(:commit).and_return("sha")
   end
 
+  it_behaves_like "a dependency file fetcher"
+
   context "with an elm.json" do
     before do
       stub_request(:get, url + "?ref=sha")

elm/spec/dependabot/elm/file_updater_spec.rb

@@ -54,10 +54,10 @@
     )
   end
 
-  it_behaves_like "a dependency file updater"
-
   before { FileUtils.mkdir_p(tmp_path) }
 
+  it_behaves_like "a dependency file updater"
+
   describe "#updated_dependency_files" do
     subject(:updated_files) { updater.updated_dependency_files }
 

git_submodules/spec/dependabot/git_submodules/metadata_finder_spec.rb

@@ -42,8 +42,6 @@
     )
   end
 
-  it_behaves_like "a dependency metadata finder"
-
   before do
     # Not hosted on GitHub Enterprise Server
     stub_request(:get, "https://example.com/status").to_return(
@@ -53,6 +51,8 @@
     )
   end
 
+  it_behaves_like "a dependency metadata finder"
+
   describe "#source_url" do
     subject(:source_url) { finder.source_url }
 

github_actions/spec/dependabot/github_actions/file_fetcher_spec.rb

@@ -28,10 +28,10 @@
     )
   end
 
-  it_behaves_like "a dependency file fetcher"
-
   before { allow(file_fetcher_instance).to receive(:commit).and_return("sha") }
 
+  it_behaves_like "a dependency file fetcher"
+
   context "with workflow files" do
     before do
       stub_request(:get, url + "?ref=sha")

github_actions/spec/dependabot/github_actions/file_parser_spec.rb

@@ -252,14 +252,14 @@ def mock_service_pack_request(nwo)
         }]
       end
 
-      its(:length) { is_expected.to eq(4) }
-
       before do
         mock_service_pack_request("docker/setup-qemu-action")
         mock_service_pack_request("docker/setup-buildx-action")
         mock_service_pack_request("docker/login-action")
       end
 
+      its(:length) { is_expected.to eq(4) }
+
       context "when dealing with the first dependency" do
         subject(:dependency) { dependencies.first }
 

github_actions/spec/dependabot/github_actions/update_checker_spec.rb

@@ -64,8 +64,6 @@
     )
   end
 
-  it_behaves_like "an update checker"
-
   before do
     stub_request(:get, service_pack_url)
       .to_return(
@@ -77,6 +75,8 @@
       )
   end
 
+  it_behaves_like "an update checker"
+
   shared_context "with multiple git sources" do
     let(:upload_pack_fixture) { "checkout" }
     let(:dependency_name) { "actions/checkout" }

go_modules/spec/dependabot/go_modules/file_fetcher_spec.rb

@@ -23,12 +23,12 @@
   let(:branch) { "master" }
   let(:repo) { "dependabot-fixtures/go-modules-lib" }
 
-  it_behaves_like "a dependency file fetcher"
-
   after do
     FileUtils.rm_rf(repo_contents_path)
   end
 
+  it_behaves_like "a dependency file fetcher"
+
   it "fetches the go.mod and go.sum" do
     expect(file_fetcher_instance.files.map(&:name))
       .to include("go.mod", "go.sum")

go_modules/spec/dependabot/go_modules/file_parser_spec.rb

@@ -30,13 +30,13 @@
   let(:files) { [go_mod] }
   let(:parser) { described_class.new(dependency_files: files, source: source, repo_contents_path: repo_contents_path) }
 
-  it_behaves_like "a dependency file parser"
-
   after do
     # Reset to the default go toolchain after each test
     ENV["GOTOOLCHAIN"] = ENV.fetch("GO_LEGACY")
   end
 
+  it_behaves_like "a dependency file parser"
+
   it "requires a go.mod to be present" do
     expect do
       described_class.new(dependency_files: [], source: source)

gradle/spec/dependabot/gradle/file_fetcher_spec.rb

@@ -28,6 +28,8 @@
     )
   end
 
+  before { allow(file_fetcher_instance).to receive(:commit).and_return("sha") }
+
   it_behaves_like "a dependency file fetcher"
 
   def stub_content_request(path, fixture)
@@ -46,8 +48,6 @@ def stub_no_content_request(path)
       .to_return(status: 404)
   end
 
-  before { allow(file_fetcher_instance).to receive(:commit).and_return("sha") }
-
   context "with a basic buildfile" do
     before do
       stub_no_content_request("gradle?ref=sha")