Skip to content

Commit

Permalink
added update job error api back to base command
Browse files Browse the repository at this point in the history
  • Loading branch information
deivid-rodriguez committed Oct 5, 2023
1 parent a6a935c commit b10685c
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions updater/lib/dependabot/base_command.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ def run
def handle_exception(err)
Dependabot.logger.error(err.message)
err.backtrace.each { |line| Dependabot.logger.error(line) }
service.capture_exception(error: err, job: job)
service.record_update_job_error(error_type: "unknown_error", error_details: { message: err.message })
# We don't set this flag in GHES because there older GHES version does not support reporting unknown errors.
handle_unknown_error(err) if Experiments.enabled?(:record_update_job_unknown_error)
end

def handle_unknown_error(err)
error_details = {
"error-class" => err.class.to_s,
"error-message" => err.message,
Expand All @@ -73,8 +80,6 @@ def handle_exception(err)
"job-dependencies" => job.dependencies,
"job-dependency_group" => job.dependency_groups
}.compact

service.capture_exception(error: err, job: job)
service.record_update_job_unknown_error(error_type: "updater_error", error_details: error_details)
service.increment_metric("updater.update_job_unknown_error", tags: {
package_manager: job.package_manager,
Expand Down

0 comments on commit b10685c

Please sign in to comment.