#5246:removing the leading underscore restriction in the package naming.

dependabot · Apr 23, 2024 · b2b3cfe · b2b3cfe
1 parent 7bbbb96
commit b2b3cfe
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/package_name.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/package_name.rb
@@ -19,7 +19,7 @@ class PackageName
             [a-z0-9\-\_\.\!\~\*\'\(\)]+               # URL-safe characters
           )\/)?
           (?<name>                                    # capture package name
-            (?=[^\.\_])                               # reject leading dot or underscore
+            (?=[^\.])                               # reject leading dot or underscore
             [a-z0-9\-\_\.\!\~\*\'\(\)]+               # URL-safe characters
           )
           \z                                          # end of string

diff --git a/npm_and_yarn/spec/dependabot/npm_and_yarn/package_name_spec.rb b/npm_and_yarn/spec/dependabot/npm_and_yarn/package_name_spec.rb
@@ -19,7 +19,6 @@
     it "raises an error for invalid package names" do
       expect { described_class.new("") }.to raise_error(described_class::InvalidPackageName)
       expect { described_class.new(".leading-dot") }.to raise_error(described_class::InvalidPackageName)
-      expect { described_class.new("_leading-underscore") }.to raise_error(described_class::InvalidPackageName)
 
       expect do
         described_class.new(" leading-space:and:weirdchars")