Merge pull request #9517 from dependabot/harry/hh170424

hh170424: Fixing the sorbet type errors.
dependabot · Apr 17, 2024 · b6f86b6 · b6f86b6
2 parents cc82ae4 + b65a890
commit b6f86b6
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 10 deletions.
diff --git a/common/lib/dependabot/clients/azure.rb b/common/lib/dependabot/clients/azure.rb
@@ -176,7 +176,7 @@ def pull_requests(source_branch, target_branch)
           base_commit: String,
           commit_message: String,
           files: T::Array[Dependabot::DependencyFile],
-          author_details: T.nilable(T::Hash[String, String])
+          author_details: T.nilable(T::Hash[Symbol, String])
         )
           .returns(T.untyped)
       end

diff --git a/common/lib/dependabot/clients/codecommit.rb b/common/lib/dependabot/clients/codecommit.rb
@@ -246,7 +246,7 @@ def create_branch(repo, branch_name, commit_id)
       sig do
         params(
           branch_name: String,
-          author_name: String,
+          author_name: T.nilable(String),
           base_commit: String,
           commit_message: String,
           files: T::Array[Dependabot::DependencyFile]

diff --git a/common/lib/dependabot/metadata_finders/base.rb b/common/lib/dependabot/metadata_finders/base.rb
@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "sorbet-runtime"

diff --git a/common/lib/dependabot/pull_request_creator/bitbucket.rb b/common/lib/dependabot/pull_request_creator/bitbucket.rb
@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "sorbet-runtime"
@@ -134,7 +134,7 @@ def create_commit
           base_commit,
           commit_message,
           files,
-          author
+          T.must(author)
         )
       end
 

diff --git a/common/lib/dependabot/pull_request_creator/codecommit.rb b/common/lib/dependabot/pull_request_creator/codecommit.rb
@@ -197,12 +197,11 @@ def pull_requests_for_branch
 
       sig { void }
       def create_commit
-        author = author_details&.slice(:name, :email, :date)
-        author = nil unless author&.any?
+        author = author_details&.slice(:name, :email, :date)&.values&.first
 
         codecommit_client_for_source.create_commit(
           branch_name,
-          author,
+          author.to_s,
           base_commit,
           commit_message,
           files

diff --git a/common/spec/fixtures/projects/simple/Gemfile b/common/spec/fixtures/projects/simple/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 gem "activesupport", ">= 6.0.0"
diff --git a/elm/lib/dependabot/elm/file_fetcher.rb b/elm/lib/dependabot/elm/file_fetcher.rb
@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "sorbet-runtime"

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/sub_dependency_files_filterer.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/sub_dependency_files_filterer.rb
@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "dependabot/utils"