Don't depend on flake8 at runtime

dependabot · Mar 14, 2023 · c2aa020 · c2aa020
1 parent 6c0e305
commit c2aa020
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/python/helpers/dev-requirements.txt b/python/helpers/dev-requirements.txt
@@ -0,0 +1 @@
+flake8==5.0.4
diff --git a/python/helpers/requirements.txt b/python/helpers/requirements.txt
@@ -1,6 +1,5 @@
 pip>=21.3.1,<23.1.0  # Range maintains py36 support TODO: Review python 3.6 support in April 2023 (eol ubuntu 18.04)
 pip-tools>=6.4.0,<=6.12.3  # Range maintains py36 support TODO: Review python 3.6 support in April 2023 (eol ubuntu 18.04)
-flake8==5.0.4
 hashin==0.17.0
 pipenv==2022.4.8
 pipfile==0.0.2

diff --git a/python/script/ci-test b/python/script/ci-test
@@ -2,6 +2,16 @@
 
 set -e
 
+# Not yet true but sets the example to follow after Python 3.6 support is dropped
+OLDEST_SUPPORTED_PYTHON=3.7
+
+if [ -s /usr/local/.pyenv/$OLDEST_SUPPORTED_PYTHON.tar.gz ]
+then
+  tar xzf /usr/local/.pyenv/$OLDEST_SUPPORTED_PYTHON.tar.gz -C /usr/local/.pyenv/
+fi
+
+PYENV_VERSION=$OLDEST_SUPPORTED_PYTHON pyenv exec pip --disable-pip-version-check install --use-pep517 -r "helpers/dev-requirements.txt"
 bundle install
-pyenv exec flake8 helpers/. --count --exclude=./.*,./python/spec/fixtures --show-source --statistics
+
+PYENV_VERSION=$OLDEST_SUPPORTED_PYTHON pyenv exec flake8 helpers/. --count --exclude=./.*,./python/spec/fixtures --show-source --statistics
 bundle exec parallel_test spec/ -n "$CI_NODE_TOTAL" --only-group "$CI_NODE_INDEX" --group-by filesize --type rspec